On 2.6.2015 13:15, Tomas Hozza wrote: > On 05/28/2015 05:58 PM, Matus Honek wrote: >> Hi, >> >> functionality seems to work fine. I have not checked the code thoroughly. >> Kind of a test is attached (requires setting named's ldap connection >> appropriately). >> >> ACK >> >> Matúš Honěk >> >> >> ----- Original Message ----- >> From: "Petr Spacek" <pspa...@redhat.com> >> To: tho...@redhat.com, "Matus Honek" <mho...@redhat.com> >> Cc: freeipa-devel@redhat.com >> Sent: Wednesday, May 27, 2015 2:50:52 PM >> Subject: [PATCH 0377-0382] Synchronize changes from LDAP after reconnect >> >> Hello, >> >> https://fedorahosted.org/bind-dyndb-ldap/ticket/128 >> >> Previously records deleted when connection to LDAP server was down were not >> synchronized properly. It should work now. >> >> I use this command to simulate broken connections and connection >> re-establishment: >> $ socat tcp-listen:3899,reuseaddr,fork tcp-connect:localhost:389 >> >> It should be enough to add "ldap://$(hostname):3899" as LDAP URI to >> /etc/named.conf and then simulate changes by killing and restarting socat. >> >> Let me know if you need any assistance! >> > Hi. > > I did a formal review of the code. Everything looks good. > > ACK.
Thank you very much! Pushed to master: 9b4a6373c868f8858253d5e9bf850e1cbbed2a7f Avoid synchronization state resets. 783b04c87575205388a1277da8b46a781508f4a7 Consolidate synchronization state machine to sync_state_change(). c727f40cae75b9f2e05f2789bade937c90202f11 On reconnect, detect and delete RBT nodes which were removed from LDAP. 77ecee87f551567b94bd26290c734c7feb5ed93f Add iterators for dead nodes in metaLDAP. b476041bd6a88b88cd1739e61960a666868e1b23 Increment MetaLDAP generation number on reconnect. 57e87e325bbfe60709a53c8d5422339bb5f2b664 Add functions for MetaLDAP generation number manipulation. We are well on track to 8.0 release :-) -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
