On 05.10.2015 16:37, Martin Basti wrote: > > > On 10/05/2015 03:31 PM, Simo Sorce wrote: >> On 05/10/15 09:08, Timo Aaltonen wrote: >>> >>> Hi >>> >>> Here are a few prep patches to get off the list before getting to >>> discuss how to add Debian platform support.. >>> >> >> LGTM. >> >> Simo. >> >> > > IMO this should be written in this way (I didn't test) > > ipautil.run([paths.GENERATE_RNDC_KEY])
Yes you're right, here's an updated version. -- t
From 49f2158b4be10b3e82392eda55909f94ee581c1a Mon Sep 17 00:00:00 2001 From: Timo Aaltonen <tjaal...@debian.org> Date: Sat, 3 Oct 2015 11:40:15 +0300 Subject: [PATCH] paths: Add GENERATE_RNDC_KEY. --- ipaplatform/base/paths.py | 1 + ipaserver/install/bindinstance.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ipaplatform/base/paths.py b/ipaplatform/base/paths.py index a272143d0053451c017c0df613951cc0e6d52c54..0d2c4c17769ef643ba2d6c9991d910cf6e00858d 100644 --- a/ipaplatform/base/paths.py +++ b/ipaplatform/base/paths.py @@ -210,6 +210,7 @@ class BasePathNamespace(object): DOGTAG_IPA_CA_RENEW_AGENT_SUBMIT = "/usr/libexec/certmonger/dogtag-ipa-ca-renew-agent-submit" DOGTAG_IPA_RENEW_AGENT_SUBMIT = "/usr/libexec/certmonger/dogtag-ipa-renew-agent-submit" IPA_SERVER_GUARD = "/usr/libexec/certmonger/ipa-server-guard" + GENERATE_RNDC_KEY = "/usr/libexec/generate-rndc-key.sh" IPA_DNSKEYSYNCD_REPLICA = "/usr/libexec/ipa/ipa-dnskeysync-replica" IPA_DNSKEYSYNCD = "/usr/libexec/ipa/ipa-dnskeysyncd" IPA_ODS_EXPORTER = "/usr/libexec/ipa/ipa-ods-exporter" diff --git a/ipaserver/install/bindinstance.py b/ipaserver/install/bindinstance.py index 771f13b00e37a6bf510ff46fe880240c84356761..9a9ef1af8a7b1cf438994489c895aec37102547b 100644 --- a/ipaserver/install/bindinstance.py +++ b/ipaserver/install/bindinstance.py @@ -1002,7 +1002,7 @@ class BindInstance(service.Service): def __generate_rndc_key(self): installutils.check_entropy() - ipautil.run(['/usr/libexec/generate-rndc-key.sh']) + ipautil.run([paths.GENERATE_RNDC_KEY]) def add_master_dns_records(self, fqdn, ip_addresses, realm_name, domain_name, reverse_zones, ntp=False, ca_configured=None): -- 2.5.0
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code