On 27.10.2015 19:00, Martin Babinsky wrote:
On 10/27/2015 10:43 AM, Martin Basti wrote:
On 26.10.2015 10:35, Martin Babinsky wrote:
On 10/23/2015 05:18 PM, Martin Basti wrote:
On 23.10.2015 15:15, Martin Babinsky wrote:
On 10/23/2015 03:12 PM, Martin Babinsky wrote:
On 10/16/2015 12:41 PM, Martin Basti wrote:
https://fedorahosted.org/freeipa/ticket/5345
Patch attached.
I have tested it on 4-2 branch and it works as expected, ACK.
Obviously, master branch would require a different patch.
I actually missed your check in ipaserver/install/kra.py which can
break ipa-replica-install with --setup-kra, so NACK.
Updated patches attached.
NACK on the master-branch patch.
You forgot a 'return' in this code snippet:
+ if self.installing_replica:
+ domain_level = dsinstance.get_domain_level(api)
+ if domain_level > DOMAIN_LEVEL_0:
+ self.options.promote = True
+ return
that would make installation abort when domain level is greter than
zero.
Updated patch attached.
ACK.
Pushed to ipa-4-2: 0f77745c5033ee321447a86a0499865c3c4b29e4
Pushed to master: 4ec8df27392b4f47c03c2cded26d6695d8c38186
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
