On 25.11.2015 13:36, Petr Spacek wrote:
On 19.11.2015 11:05, Martin Basti wrote:
On 18.11.2015 18:33, Petr Spacek wrote:
On 12.11.2015 13:58, Martin Basti wrote:
On 09.11.2015 08:47, Petr Spacek wrote:
On 4.11.2015 16:16, Martin Basti wrote:
Patch attached.
https://fedorahosted.org/freeipa/ticket/5421
I'm not entirely sure how this patch will interact with magic included in
ipalib/plugins/dns.py:class dns_resolve(Command).
I would like to delete the 'normalization' from at least one of these places.
Also, as you know, DNS names are not strings and should be manipulated using
python-dns so all crazy things in DNS names do not break in weird corner
cases.
Updated patch attached.
Hmm, you bravely ignored my comment about class dns_resolve(Command) above,
sooo: NACK.
As far as I can tell ipalib/plugins/dns.py:class dns_resolve(Command) behaves
in the same brain-dead way as original is_host_resolvable() function. Please
fix both, not just one.
If you are sure that the behavior of the dns-resolve is bad, then updated
patch that removes the code which appending the api.env.domain to query.
Patch attached.
ACK
Pushed to master: 800c7023241fd6182da300cf120870072e6ca602
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
