New pylint version will broke our custom make-lint script again,
attached patch migrates make-lint to:
* config file
* pylint plugin
which are supported by pylint and should not have regular compatibility
issues
to test new approach run ./make-lint2
Advantages:
* compatibility with pylint
* works on both pylint-1.4.3-3.fc23.noarch and pylint-1.5.2-1.fc24.noarch
* pylint plugin works in different way than the previous custom checker.
Missing ("dynamic") attributes are added to abstract syntax tree instead
of ignoring them and all their sub-members. This makes check better,
pylint can detect more typos in tests configurations, api, env, etc..
Disadvantages:
* any new attribute in api, test config, etc.. must be added to
definition of missing members (pylint plugin) - this should not happen
too often
Q&TODO:
* make-lint: should it be just bash script or rather python script?
* add dynamic detection of python files to be checked
* should I keep the current options from original make-lint?
* several false positive errors I haven't been able to fix in plugin
yet, in worst case they can be locally disabled:
************* Module ipalib.plugins.vault
ipalib/plugins/vault.py:1654: [E1101(no-member), vault_archive.forward]
Class 'subject_public_key_info' has no 'public_key' member)
ipalib/plugins/vault.py:1858: [E1101(no-member), vault_retrieve.forward]
Class 'subject_public_key_info' has no 'public_key' member)
************* Module ipatests.test_ipapython.test_ipautil
ipatests/test_ipapython/test_ipautil.py:390: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'houroffset' member)
ipatests/test_ipapython/test_ipautil.py:391: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'minoffset' member)
ipatests/test_ipapython/test_ipautil.py:392: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'utcoffset' member)
ipatests/test_ipapython/test_ipautil.py:392: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'dst' member)
ipatests/test_ipapython/test_ipautil.py:398: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'houroffset' member)
ipatests/test_ipapython/test_ipautil.py:399: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'minoffset' member)
ipatests/test_ipapython/test_ipautil.py:400: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'utcoffset' member)
ipatests/test_ipapython/test_ipautil.py:400: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'dst' member)
ipatests/test_ipapython/test_ipautil.py:406: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'houroffset' member)
ipatests/test_ipapython/test_ipautil.py:407: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'minoffset' member)
ipatests/test_ipapython/test_ipautil.py:410: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'utcoffset' member)
ipatests/test_ipapython/test_ipautil.py:410: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'dst' member)
ipatests/test_ipapython/test_ipautil.py:416: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'houroffset' member)
ipatests/test_ipapython/test_ipautil.py:417: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'minoffset' member)
ipatests/test_ipapython/test_ipautil.py:418: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'utcoffset' member)
ipatests/test_ipapython/test_ipautil.py:418: [E1101(no-member),
TestTimeParser.test_time_zones] Class 'tzinfo' has no 'dst' member)
From e322273a7e5dd6fa5d8f5fb799a09f0130aab0f2 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Fri, 15 Jan 2016 16:58:38 +0100
Subject: [PATCH] WIP: make-lint: use config file and plugin for pylint
Our custom implementation of pylint checker is often broken by
incompatible change on pylint side. Using supported solutions (config
file, pylint plugins) should avoid this issue.
The plugin adds missing (dynamic) member to classes in abstract syntax
tree generated for pylint, instead of just ignoring missing members and
all sub-members. This should improve pylint detection of typos and
missing members in api. env and test config.
https://fedorahosted.org/freeipa/ticket/5615
---
make-lint2 | 70 +++++++
pylint_plugins/__init__.py | 0
pylint_plugins/fix_ipa_members.py | 211 ++++++++++++++++++++
pylintrc | 404 ++++++++++++++++++++++++++++++++++++++
4 files changed, 685 insertions(+)
create mode 100755 make-lint2
create mode 100644 pylint_plugins/__init__.py
create mode 100644 pylint_plugins/fix_ipa_members.py
create mode 100644 pylintrc
diff --git a/make-lint2 b/make-lint2
new file mode 100755
index 0000000000000000000000000000000000000000..7c1c6453c189618fcf7e7e19ab91aebd580b4dbd
--- /dev/null
+++ b/make-lint2
@@ -0,0 +1,70 @@
+#!/usr/bin/bash
+
+FILES=(
+ daemons/dnssec/ipa-dnskeysyncd
+ daemons/dnssec/ipa-dnskeysync-replica
+ daemons/dnssec/ipa-ods-exporter
+ daemons/ipa-otpd/test.py
+ setup-client.py
+ ipalib
+ ipaplatform
+ ipapython
+ checks/check-ra.py
+ pylint_plugins
+ ipatests
+ makeapi
+ ipaserver
+ setup.py
+ install/certmonger/ipa-server-guard
+ install/certmonger/dogtag-ipa-ca-renew-agent-submit
+ install/wsgi/plugins.py
+ install/restart_scripts/renew_ra_cert
+ install/restart_scripts/renew_ra_cert_pre
+ install/restart_scripts/stop_pkicad
+ install/restart_scripts/renew_ca_cert
+ install/restart_scripts/restart_dirsrv
+ install/restart_scripts/restart_httpd
+ install/migration/migration.py
+ install/oddjob/com.redhat.idm.trust-fetch-domains
+ install/tools/ipa-replica-manage
+ install/tools/ipa-compat-manage
+ install/tools/ipa-winsync-migrate
+ install/tools/ipa-backup
+ install/tools/ipa-ldap-updater
+ install/tools/ipa-httpd-kdcproxy
+ install/tools/ipa-cacert-manage
+ install/tools/ipa-nis-manage
+ install/tools/ipa-kra-install
+ install/tools/ipa-dns-install
+ install/tools/ipa-ca-install
+ install/tools/ipa-replica-install
+ install/tools/ipa-server-certinstall
+ install/tools/ipa-otptoken-import
+ install/tools/ipa-upgradeconfig
+ install/tools/ipactl
+ install/tools/ipa-replica-conncheck
+ install/tools/ipa-adtrust-install
+ install/tools/ipa-advise
+ install/tools/ipa-csreplica-manage
+ install/tools/ipa-replica-prepare
+ install/tools/ipa-server-install
+ install/tools/ipa-managed-entries
+ install/tools/ipa-restore
+ install/tools/ipa-server-upgrade
+ install/share/copy-schema-to-ca.py
+ install/share/wsgi.py
+ doc/examples/python-api.py
+ doc/examples/examples.py
+ ipa
+ ipa-client/ipaclient
+ ipa-client/ipa-install/ipa-client-install
+ ipa-client/ipa-install/ipa-certupdate
+ ipa-client/ipa-install/ipa-client-automount
+ makeaci
+)
+
+PYTHONPATH=`pwd`/pylint_plugins pylint --load-plugins fix_ipa_members ${FILES[*]}
+echo EXIT $?
+
+PYTHONPATH=`pwd`/pylint_plugins pylint --py3k -d no-absolute-import --load-plugins fix_ipa_members ${FILES[*]}
+echo EXIT $?
diff --git a/pylint_plugins/__init__.py b/pylint_plugins/__init__.py
new file mode 100644
index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
diff --git a/pylint_plugins/fix_ipa_members.py b/pylint_plugins/fix_ipa_members.py
new file mode 100644
index 0000000000000000000000000000000000000000..b9a723829c48ebf986015699ab88bd538adf954c
--- /dev/null
+++ b/pylint_plugins/fix_ipa_members.py
@@ -0,0 +1,211 @@
+#
+# Copyright (C) 2015 FreeIPA Contributors see COPYING for license
+#
+
+from __future__ import print_function
+
+import copy
+import sys
+
+from astroid import MANAGER
+from astroid import scoped_nodes
+
+
+def register(linter):
+ pass
+
+
+def _warning_already_exists(cls, member):
+ print(
+ "WARNING: member '{member}' in '{cls}' already exists".format(
+ cls="{}.{}".format(cls.root().name, cls.name), member=member),
+ file=sys.stderr
+ )
+
+
+def fake_class(name_or_class_obj, members=[]):
+ if isinstance(name_or_class_obj, scoped_nodes.Class):
+ cl = name_or_class_obj
+ else:
+ cl = scoped_nodes.Class(name_or_class_obj, None)
+
+ for m in members:
+ if isinstance(m, str):
+ if m in cl.locals:
+ _warning_already_exists(cl, m)
+ else:
+ cl.locals[m] = [scoped_nodes.Class(m, None)]
+ elif isinstance(m, dict):
+ for key, val in m.items():
+ assert isinstance(key, str), "key must be string"
+ if key in cl.locals:
+ _warning_already_exists(cl, key)
+ fake_class(cl.locals[key], val)
+ else:
+ cl.locals[key] = [fake_class(key, val)]
+ else:
+ # here can be used any astroid type
+ if m.name in cl.locals:
+ _warning_already_exists(cl, m.name)
+ else:
+ cl.locals[m.name] = [copy.copy(m)]
+ return cl
+
+
+fake_backend = {'Backend': [
+ {'wsgi_dispatch': ['mount']},
+]}
+
+NAMESPACE_ATTRS = ['Command', 'Object', 'Method', fake_backend, 'Updater',
+ 'Advice']
+fake_api_env = {'env': [
+ 'host',
+ 'realm',
+ 'session_auth_duration',
+ 'session_duration_type',
+]}
+
+# this is due ipaserver.rpcserver.KerberosSession where api is undefined
+fake_api = {'api': [fake_api_env] + NAMESPACE_ATTRS}
+
+_LOGGING_ATTRS = ['debug', 'info', 'warning', 'error', 'exception',
+ 'critical']
+LOGGING_ATTRS = [
+ {'log': _LOGGING_ATTRS},
+] + _LOGGING_ATTRS
+
+# 'class': ['generated', 'properties']
+ipa_class_members = {
+ # Python standard library & 3rd party classes
+ 'socket._socketobject': ['sendall'],
+# !!! 'datetime.tzinfo': ['houroffset', 'minoffset', 'utcoffset', 'dst'],
+# !!! 'nss.nss.subject_public_key_info': ['public_key'],
+
+ # IPA classes
+ 'ipalib.base.NameSpace': [
+ 'add',
+ 'mod',
+ 'del',
+ 'show',
+ 'find'
+ ],
+ 'ipalib.cli.Collector': ['__options'],
+ 'ipalib.config.Env': [
+ {'__d': ['get']},
+ {'__done': ['add']},
+ 'xmlrpc_uri',
+ 'validate_api',
+ 'startup_traceback',
+ 'verbose'
+ ] + LOGGING_ATTRS,
+ 'ipalib.parameters.Param': [
+ 'cli_name',
+ 'cli_short_name',
+ 'label',
+ 'default',
+ 'doc',
+ 'required',
+ 'multivalue',
+ 'primary_key',
+ 'normalizer',
+ 'default_from',
+ 'autofill',
+ 'query',
+ 'attribute',
+ 'include',
+ 'exclude',
+ 'flags',
+ 'hint',
+ 'alwaysask',
+ 'sortorder',
+ 'csv',
+ 'option_group',
+ ],
+ 'ipalib.parameters.Bool': [
+ 'truths',
+ 'falsehoods'],
+ 'ipalib.parameters.Data': [
+ 'minlength',
+ 'maxlength',
+ 'length',
+ 'pattern',
+ 'pattern_errmsg',
+ ],
+ 'ipalib.parameters.Str': ['noextrawhitespace'],
+ 'ipalib.parameters.Password': ['confirm'],
+ 'ipalib.parameters.File': ['stdin_if_missing'],
+ 'ipalib.plugins.dns.DNSRecord': [
+ 'validatedns',
+ 'normalizedns',
+ ],
+ 'ipalib.parameters.Enum': ['values'],
+ 'ipalib.parameters.Number': [
+ 'minvalue',
+ 'maxvalue',
+ ],
+ 'ipalib.parameters.Decimal': [
+ 'precision',
+ 'exponential',
+ 'numberclass',
+ ],
+ 'ipalib.parameters.DNSNameParam': [
+ 'only_absolute',
+ 'only_relative',
+ ],
+ 'ipalib.plugable.API': [
+ fake_api_env,
+ ] + NAMESPACE_ATTRS + LOGGING_ATTRS,
+ 'ipalib.plugable.Plugin': [
+ 'Object',
+ 'Method',
+ 'Updater',
+ 'Advice',
+ ] + LOGGING_ATTRS,
+ 'ipalib.session.AuthManager': LOGGING_ATTRS,
+ 'ipalib.session.SessionAuthManager': LOGGING_ATTRS,
+ 'ipalib.session.SessionManager': LOGGING_ATTRS,
+ 'ipaserver.install.ldapupdate.LDAPUpdate': LOGGING_ATTRS,
+ 'ipaserver.rpcserver.KerberosSession': [
+ fake_api,
+ ] + LOGGING_ATTRS,
+ 'ipatests.test_integration.base.IntegrationTest': [
+ 'domain',
+ {'master': [
+ {'config': [
+ {'dirman_password': dir(str)},
+ {'admin_password': dir(str)},
+ {'admin_name': dir(str)},
+ {'dns_forwarder': dir(str)},
+ {'test_dir': dir(str)},
+ {'ad_admin_name': dir(str)},
+ {'ad_admin_password': dir(str)},
+ ]},
+ {'domain': [
+ {'realm': dir(str)},
+ {'name': dir(str)},
+ ]},
+ 'hostname',
+ 'ip',
+ 'collect_log',
+ {'run_command': [
+ {'stdout_text': dir(str)},
+ 'stderr_text',
+ 'returncode',
+ ]},
+ {'transport': ['put_file']},
+ 'put_file_contents',
+ 'get_file_contents',
+ ]},
+ 'replicas',
+ 'clients',
+ 'ad_domains',
+ ]
+}
+
+
+def fix_ipa_classes(cls):
+ class_name_with_module = "{}.{}".format(cls.root().name, cls.name)
+ if class_name_with_module in ipa_class_members:
+ fake_class(cls, ipa_class_members[class_name_with_module])
+
+MANAGER.register_transform(scoped_nodes.Class, fix_ipa_classes)
diff --git a/pylintrc b/pylintrc
new file mode 100644
index 0000000000000000000000000000000000000000..a6c854059c47cd5808fd343a946fd39d4a8ebfa0
--- /dev/null
+++ b/pylintrc
@@ -0,0 +1,404 @@
+[MASTER]
+
+# Specify a configuration file.
+#rcfile=
+
+# Python code to execute, usually for sys.path manipulation such as
+# pygtk.require().
+#init-hook=
+
+# Add files or directories to the blacklist. They should be base names, not
+# paths.
+ignore=CVS
+
+# Pickle collected data for later comparisons.
+persistent=no
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
+load-plugins=
+
+# Use multiple processes to speed up Pylint.
+jobs=1
+
+# Allow loading of arbitrary C extensions. Extensions are imported into the
+# active Python interpreter and may run arbitrary code.
+unsafe-load-any-extension=no
+
+# A comma-separated list of package or module names from where C extensions may
+# be loaded. Extensions are loading into the active Python interpreter and may
+# run arbitrary code
+extension-pkg-whitelist=
+
+# Allow optimization of some AST trees. This will activate a peephole AST
+# optimizer, which will apply various small optimizations. For instance, it can
+# be used to obtain the result of joining multiple strings with the addition
+# operator. Joining a lot of strings can lead to a maximum recursion error in
+# Pylint and this flag can prevent that. It has one side effect, the resulting
+# AST will be different than the one from reality.
+optimize-ast=no
+
+
+[MESSAGES CONTROL]
+
+# Only show warnings with the listed confidence levels. Leave empty to show
+# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED
+confidence=
+
+enable=all
+
+disable=
+ R,
+ I,
+ invalid-name,
+ import-error,
+ abstract-method,
+ anomalous-backslash-in-string,
+ arguments-differ,
+ attribute-defined-outside-init,
+ bad-builtin,
+ bad-indentation,
+ bare-except,
+ broad-except,
+ dangerous-default-value,
+ eval-used,
+ exec-used,
+ fixme,
+ global-statement,
+ global-variable-not-assigned,
+ global-variable-undefined,
+ no-init,
+ pointless-except,
+ pointless-statement,
+ pointless-string-statement,
+ protected-access,
+ redefine-in-handler,
+ redefined-builtin,
+ redefined-outer-name,
+ reimported,
+ relative-import,
+ super-init-not-called,
+ undefined-loop-variable,
+ unnecessary-lambda,
+ unnecessary-semicolon,
+ unused-argument,
+ unused-variable,
+ useless-else-on-loop,
+ bad-classmethod-argument,
+ bad-continuation,
+ bad-mcs-classmethod-argument,
+ bad-mcs-method-argument,
+ bad-whitespace,
+ blacklisted-name,
+ invalid-name,
+ line-too-long,
+ missing-docstring,
+ multiple-imports,
+ multiple-statements,
+ old-style-class,
+ superfluous-parens,
+ too-many-lines,
+ unidiomatic-typecheck,
+ python3
+
+
+[REPORTS]
+
+# Set the output format. Available formats are text, parseable, colorized, msvs
+# (visual studio) and html. You can also give a reporter class, eg
+# mypackage.mymodule.MyReporterClass.
+output-format=text
+
+# Put messages in a separate file for each module / package specified on the
+# command line instead of printing them on stdout. Reports (if any) will be
+# written in a file name "pylint_global.[txt|html]".
+files-output=no
+
+# Tells whether to display a full report or only the messages
+reports=no
+
+# Python expression which should return a note less than 10 (10 is the highest
+# note). You have access to the variables errors warning, statement which
+# respectively contain the number of errors / warnings messages and the total
+# number of statements analyzed. This is used by the global evaluation report
+# (RP0004).
+evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
+
+# Template used to display messages. This is a python new-style format string
+# used to format the message information. See doc for all details
+msg-template='{path}:{line}: [{msg_id}({symbol}), {obj}] {msg})'
+
+
+[SIMILARITIES]
+
+# Minimum lines number of a similarity.
+min-similarity-lines=4
+
+# Ignore comments when computing similarities.
+ignore-comments=yes
+
+# Ignore docstrings when computing similarities.
+ignore-docstrings=yes
+
+# Ignore imports when computing similarities.
+ignore-imports=no
+
+
+[LOGGING]
+
+# Logging modules to check that the string format arguments are in logging
+# function parameter format
+logging-modules=logging
+
+
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of module names for which member attributes should not be checked
+# (useful for modules/projects where namespaces are manipulated during runtime
+# and thus existing member attributes cannot be deduced by static analysis
+ignored-modules=
+
+# List of classes names for which member attributes should not be checked
+# (useful for classes with attributes dynamically set).
+ignored-classes=SQLObject
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E0201 when accessed. Python regular
+# expressions are accepted.
+generated-members=REQUEST,acl_users,aq_parent
+
+
+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,XXX,TODO
+
+
+[SPELLING]
+
+# Spelling dictionary name. Available dictionaries: none. To make it working
+# install python-enchant package.
+spelling-dict=
+
+# List of comma separated words that should not be checked.
+spelling-ignore-words=
+
+# A path to a file that contains private dictionary; one word per line.
+spelling-private-dict-file=
+
+# Tells whether to store unknown words to indicated private dictionary in
+# --spelling-private-dict-file option instead of raising a message.
+spelling-store-unknown-words=no
+
+
+[FORMAT]
+
+# Maximum number of characters on a single line.
+max-line-length=100
+
+# Regexp for a line that is allowed to be longer than the limit.
+ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+
+# Allow the body of an if to be on the same line as the test if there is no
+# else.
+single-line-if-stmt=no
+
+# List of optional constructs for which whitespace checking is disabled
+no-space-check=trailing-comma,dict-separator
+
+# Maximum number of lines in a module
+max-module-lines=1000
+
+# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
+# tab).
+indent-string=' '
+
+# Number of spaces of indent required inside a hanging or continued line.
+indent-after-paren=4
+
+# Expected format of line ending, e.g. empty (any line ending), LF or CRLF.
+expected-line-ending-format=
+
+
+[BASIC]
+
+# List of builtins function names that should not be used, separated by a comma
+bad-functions=map,filter,input
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=i,j,k,ex,Run,_
+
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
+
+# Colon-delimited sets of names that determine each other's naming style when
+# the name regexes allow several styles.
+name-group=
+
+# Include a hint for the correct naming format with invalid-name
+include-naming-hint=no
+
+# Regular expression matching correct function names
+function-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for function names
+function-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct variable names
+variable-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for variable names
+variable-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct constant names
+const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Naming hint for constant names
+const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Regular expression matching correct attribute names
+attr-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for attribute names
+attr-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct argument names
+argument-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for argument names
+argument-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct class attribute names
+class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Naming hint for class attribute names
+class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Regular expression matching correct inline iteration names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Naming hint for inline iteration names
+inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$
+
+# Regular expression matching correct class names
+class-rgx=[A-Z_][a-zA-Z0-9]+$
+
+# Naming hint for class names
+class-name-hint=[A-Z_][a-zA-Z0-9]+$
+
+# Regular expression matching correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Naming hint for module names
+module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Regular expression matching correct method names
+method-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for method names
+method-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression which should only match function or class names that do
+# not require a docstring.
+no-docstring-rgx=__.*__
+
+# Minimum line length for functions/classes that require docstrings, shorter
+# ones are exempt.
+docstring-min-length=-1
+
+
+[VARIABLES]
+
+# Tells whether we should check for unused import in __init__ files.
+init-import=no
+
+# A regular expression matching the name of dummy variables (i.e. expectedly
+# not used).
+dummy-variables-rgx=_$|dummy
+
+# List of additional names supposed to be defined in builtins. Remember that
+# you should avoid to define new builtins when possible.
+additional-builtins=
+
+# List of strings which can identify a callback function by name. A callback
+# name must start or end with one of those strings.
+callbacks=cb_,_cb
+
+
+[CLASSES]
+
+# List of method names used to declare (i.e. assign) instance attributes.
+defining-attr-methods=__init__,__new__,setUp
+
+# List of valid names for the first argument in a class method.
+valid-classmethod-first-arg=cls
+
+# List of valid names for the first argument in a metaclass class method.
+valid-metaclass-classmethod-first-arg=mcs
+
+# List of member names, which should be excluded from the protected access
+# warning.
+exclude-protected=_asdict,_fields,_replace,_source,_make
+
+
+[DESIGN]
+
+# Maximum number of arguments for function / method
+max-args=5
+
+# Argument names that match this expression will be ignored. Default to name
+# with leading underscore
+ignored-argument-names=_.*
+
+# Maximum number of locals for function / method body
+max-locals=15
+
+# Maximum number of return / yield for function / method body
+max-returns=6
+
+# Maximum number of branch for function / method body
+max-branches=12
+
+# Maximum number of statements in function / method body
+max-statements=50
+
+# Maximum number of parents for a class (see R0901).
+max-parents=7
+
+# Maximum number of attributes for a class (see R0902).
+max-attributes=7
+
+# Minimum number of public methods for a class (see R0903).
+min-public-methods=2
+
+# Maximum number of public methods for a class (see R0904).
+max-public-methods=20
+
+
+[IMPORTS]
+
+# Deprecated modules which should not be used, separated by a comma
+deprecated-modules=regsub,TERMIOS,Bastion,rexec
+
+# Create a graph of every (i.e. internal and external) dependencies in the
+# given file (report RP0402 must not be disabled)
+import-graph=
+
+# Create a graph of external dependencies in the given file (report RP0402 must
+# not be disabled)
+ext-import-graph=
+
+# Create a graph of internal dependencies in the given file (report RP0402 must
+# not be disabled)
+int-import-graph=
+
+
+[EXCEPTIONS]
+
+# Exceptions that will emit a warning when being caught. Defaults to
+# "Exception"
+overgeneral-exceptions=Exception
--
2.5.0
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
