On 01/18/2016 02:26 PM, Filip Skola wrote:
Hi,
this should be fixed in this patch.
F.
----- Original Message -----
On 01/15/2016 03:37 PM, Filip Skola wrote:
Hi,
sending rebased patch.
F.
----- Original Message -----
Hi,
the patch no longer applies to master. Please rebase it.
Thanks,
Milan
----- Original Message -----
From: "Filip Skola" <fsk...@redhat.com>
To: freeipa-devel@redhat.com
Cc: "Milan Kubík" <mku...@redhat.com>, "Aleš Mareček"
<amare...@redhat.com>
Sent: Tuesday, 22 December, 2015 11:56:15 AM
Subject: [PATCH 0005] Refactor test_nesting, create HostGroupTracker
Hi,
another patch from refactoring-test_xmlrpc series.
Filip
NACK, something seems to be missing in the patch
************* Module ipatests.test_xmlrpc.tracker.hostgroup_plugin
ipatests/test_xmlrpc/tracker/hostgroup_plugin.py:222: [E1101(no-member),
HostGroupTracker.check_add_member_negative] Instance of
'HostGroupTracker' has no 'adds' member)
--
Milan Kubik
The same as with patch 0002:
************* Module ipatests.test_xmlrpc.tracker.hostgroup_plugin
W:142,26: Calling a dict.iter*() method (dict-iter-method)
Please use dict.items method.
--
Milan Kubik
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code