Hey guys, could anyone review this please? On 02/19/2016 02:11 PM, Oleg Fayans wrote: > Hi Milan, > > On 02/12/2016 04:03 PM, Milan Kubík wrote: >> On 02/04/2016 08:49 AM, Oleg Fayans wrote: >>> Hi Petr, >>> >>> On 02/03/2016 02:19 PM, Petr Spacek wrote: >>>> On 3.2.2016 10:22, Oleg Fayans wrote: >>>>> Guys, can anyone take a look at this? >>>> The commit message does not explain why you are setting search path. >>> Fixed. >>> >>>> I have to say that I do not like touching resolv.conf, as stated many times >>>> earlier. Why the test has to reconfigure the host and cannot use values >>>> provided by the provisioning system? >>> This patch exactly removes this messing around with nameservers in >>> resolv.conf >>> It introduces the possibility to put ipa domain in the search directive >>> of resolv.conf so that we could test service autodiscovery during client >>> installation. >>> >>> >>> >> I just verified that the tampering with resolv.conf is not needed >> (libvirt and ovirt/rhev). I think this is an artifact from the whole >> issue of "let's use improvised domain names, what can go wrong" approach >> that was uncovered by the enforced DNS checks. I think we can defer the >> networking configuration to provisioning system. > > Agreed. The latest patch gets rid of all resolv.conf related > manipulations. The tests work (where not affected by > https://fedorahosted.org/bind-dyndb-ldap/ticket/160) > > >> >> -- >> Milan Kubik >> > > >
-- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code