On 04/28/2016 06:29 PM, Martin Basti wrote: > > > On 28.04.2016 17:27, Petr Spacek wrote: >> On 28.4.2016 16:14, Martin Basti wrote: >>> >>> On 22.04.2016 14:35, Petr Spacek wrote: >>>> On 12.4.2016 17:26, Martin Basti wrote: >>>>> On 04.04.2016 17:37, Petr Spacek wrote: >>>>>> On 31.3.2016 13:45, Martin Basti wrote: >>>>>>> On 21.03.2016 16:51, Petr Spacek wrote: >>>>>>>> On 10.3.2016 22:17, Lukas Slebodnik wrote: >>>>>>>>> On (10/03/16 22:14), Petr Spacek wrote: >>>>>>>>>> Hello, >>>>>>>>>> >>>>>>>>>> I forgot to send a patches before I leave, so here it is: >>>>>>>>>> >>>>>>>>>> Auto-detect default value for --forward-policy option in >>>>>>>>>> installers >>>>>>>>>> >>>>>>>>>> See >>>>>>>>>> https://fedorahosted.org/freeipa/ticket/5710 >>>>>>>>>> commit messages, and design page >>>>>>>>>> https://fedorahosted.org/bind-dyndb-ldap/wiki/BIND9/Design/AutomaticEmptyZones >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> I did not have time to test it thoroughly but it LGTM :-D >>>>>>>>>> >>>>>>>>>> Please note that this is first part, it does not solve upgrade >>>>>>>>>> (yet) and >>>>>>>>>> warnings in forwardzone-* interface. >>>>>>>>>> >>>>>>>>>> This can be solved in another patch set, this can be pushed if >>>>>>>>>> it passes >>>>>>>>>> review. >>>>>>>>>> >>>>>>>>> ENOPATH >>>>>>>> LOL, here it is. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> * Remove function ipapython.ipautil.host_exists() * >>>>>>> ACK >>>>>>> >>>>>>> >>>>>>> * Extend installers with --forward-policy option * >>>>>>> 1) >>>>>>> There is no --forward-policy option in ipa-dns-install >>>>>>> >>>>>>> >>>>>>> * Move automatic empty zone list into ipapython.dnsutil and make it >>>>>>> reusable * >>>>>>> ACK >>>>>>> >>>>>>> >>>>>>> * Add assert_absolute_dnsname() helper to ipapython.dnsutil * >>>>>>> ACK >>>>>>> >>>>>>> >>>>>>> * Move function is_auto_empty_zone() into ipapython.dnsutil * >>>>>>> ACK >>>>>>> >>>>>>> >>>>>>> * Use shared sanity check and tests >>>>>>> ipapython.dnsutil.is_auto_empty_zone() * >>>>>>> ACK >>>>>>> >>>>>>> * Add function ipapython.dnsutil.inside_auto_empty_zone() * >>>>>>> ACK >>>>>>> >>>>>>> * Auto-detect default value for --forward-policy option in >>>>>>> installers * >>>>>>> LGTM, but ipa-dns-install is missing option --forward-policy >>>>>>> >>>>>>> # ipa-dns-install >>>>>>> ... >>>>>>> Unexpected error - see /var/log/ipaserver-install.log for details: >>>>>>> AttributeError: Values instance has no attribute 'forward_policy' >>>>>>> >>>>>>> >>>>>>> Summary: 6 ACKs, 1 LGTM, 1 NACK => NACK >>>>>> Thank you very much for review. >>>>>> >>>>>> Here is my second attempt :-) >>>>>> >>>>> Hello, >>>>> code works as expected, but it is quite inconsistent with current >>>>> behavior >>>>> >>>>> ipa-server-install --forward-policy should raise error without >>>>> --setup-dns >>>>> option >>>>> >>>>> Like here: >>>>> [root@vm-058-134 ~]# ipa-server-install --forwarder=10.2.3.4 >>>>> Usage: ipa-server-install [options] >>>>> >>>>> ipa-server-install: error: You cannot specify a --forwarder option >>>>> without the >>>>> --setup-dns option >>>>> ipa.ipapython.install.cli.install_tool(Server): ERROR The >>>>> ipa-server-install command failed. See >>>>> /var/log/ipaserver-install.log for more >>>>> information >>>>> >>>>> Martin >>>> Fixed patches are attached. Thank you for your time! >>>> >>> almost ack but patches need rebase on ipa-4-3 >> Here you go. >> > > ACK (somebody have to push it, because I'm banned from fedora as spambot > :) and it will take time until system unblock me due to sync) >
pushed to master: * 9ee6d379c496cd1648d58a6ecca72ed41638a3f1 Remove function ipapython.ipautil.host_exists() * 89974548891baa6dbbab401913359e398a2cbc57 Extend installers with --forward-policy option * bd32b48eb0180b73c3bd769b7ea2b369a095c000 Move automatic empty zone list into ipapython.dnsutil and make it reusable * 41464b74f43ab0a7f9ad650bdaac19308fc7ff5c Add assert_absolute_dnsname() helper to ipapython.dnsutil * 6752d6404af13a933105e53ea5875adfb933e293 Move function is_auto_empty_zone() into ipapython.dnsutil * 1df30b4646d0738c5d218acf9f65b6617a970c98 Use shared sanity check and tests ipapython.dnsutil.is_auto_empty_zone() * c7ee765c4de086ac92922519d7065fc6b6796f10 Add function ipapython.dnsutil.inside_auto_empty_zone() * 51907d5bb8fce9e5358fed50c0ec7074ef7f0c69 Auto-detect default value for --forward-policy option in installers ipa-4-3: * 6dbc4ccbe42835780f7716d96ec45a9b94ed8b64 Remove function ipapython.ipautil.host_exists() * 54e26799540cbadafa08d1e975e46f261c521c81 Extend installers with --forward-policy option * 5c53cf2cd687fdd77a62dc12ed359953f547b86a Move automatic empty zone list into ipapython.dnsutil and make it reusable * 4a8dcc1cac0d96bf12fb608d3b12e81bbdf2503b Add assert_absolute_dnsname() helper to ipapython.dnsutil * ea1bf611f8b027f6a7140c532d1940eada2c6071 Move function is_auto_empty_zone() into ipapython.dnsutil * f2cf30d38cb28fb6f73a2df6a436658e548d2b10 Use shared sanity check and tests ipapython.dnsutil.is_auto_empty_zone() * fbc8a23a2ca93d998ff417fb7f9b9dcde01bddc2 Add function ipapython.dnsutil.inside_auto_empty_zone() * d145f8c78a5bcc5cc21be99be6225587b106c50a Auto-detect default value for --forward-policy option in installers -- Petr Vobornik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code