On 25.4.2016 10:12, Lukas Slebodnik wrote: > On (25/04/16 09:59), Jan Cholasta wrote: >> On 25.4.2016 09:34, Petr Spacek wrote: >>> On 25.4.2016 09:29, Lukas Slebodnik wrote: >>>> On (25/04/16 07:23), Jan Cholasta wrote: >>>>> Hi, >>>>> >>>>> On 22.4.2016 13:29, Petr Spacek wrote: >>>>>> Hello, >>>>>> >>>>>> Makefile: add sed to BuildRequires >>>>>> >>>>>> It was requried since forever but we did not explicitly mention it. >>>>> >>>>> IIRC sed is part of the minimum build environemnt and as such should not >>>>> be >>>>> explicitly required in the spec file. I personally don't care, but this is >>>>> the likely reason why it wan't there from the beginning. >>>>> >>>> +1 >>>> >>>> It is part of group "@buildsys-build". >>>> and fedora packaging guidelines does not recommend to list >>>> packages from this group in BuildRequires. >>> >>> I consider this piece of Fedora guidelines brain-dead as "explicit is better >>> than implicit". Anyway, feel free to NACK it so the status of the patch is >>> clear and this thread can die. I do not insist on it. >> >> I can't find it in the guidelines anymore, so LGTM. >> > It seems that it was changed since I read it last time. > > There is vague description of which packages should be there. > http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 > It is important that your package list all necessary build dependencies > using the BuildRequires?: > tag. You may assume that enough of an environment exists for RPM to > function > and execute basic shell scripts, but you should not assume any other > packages > are present as RPM dependencies and anything brought into the buildroot > by the build system may change over time. > > But utility fedora-review still complains if you list packages from group > "@buildsys-build"
So, should I drop the patch from my queue or not? I still think that it is brain-dead not to list dependencies explicitly but you tell me if I should remove the patch from my waiting-for-review-queue or not. -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
