On 16.06.2016 08:31, Abhijeet Kasurde wrote:
Hi All,

Please review updated patch.

On 06/15/2016 07:56 PM, Abhijeet Kasurde wrote:


On 06/15/2016 07:29 PM, Martin Basti wrote:



On 15.06.2016 11:13, Abhijeet Kasurde wrote:
Hi All,

Please review the attached patch.

Fixes: https://fedorahosted.org/freeipa/ticket/5920




Thank you for the patch,

Please follow this page for howto create internationalized strings:
http://www.freeipa.org/page/Python_Coding_Style#Python_Internationalized_.28i18n.29_Strings

you must use named subsitution, because translators may need to know what should be there, or they may change the order of words depending on translated language

Martin^2

Thanks Martin for suggestion. I will implement this in current patch and re-submit it for code review.

--
Thanks,
Abhijeet Kasurde

IRC: akasurde
http://akasurde.github.io




--
Thanks,
Abhijeet Kasurde

IRC: akasurde
http://akasurde.github.io




Thank you!
ACK
Pushed to master: 6873ac5b0370562c314ada931416c110fc51c1b2

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to