On 28.7.2016 16:35, Jan Cholasta wrote: > On 28.7.2016 16:20, Petr Spacek wrote: >> Hello, >> >> install: Call hostnamectl set-hostname only if --hostname option is used >> >> This commit also splits hostname backup and configuration into two separate >> functions. This allows us to backup hostname without setting it at the >> same time. >> >> https://fedorahosted.org/freeipa/ticket/6071 > > Note that you can set ca_host in cfg unconditionally, the value is only valid > during install and is not written anywhere.
I prefer not to set it so the code blows up when we attempt to touch variables we should reference in particular setups. I.e. Take this as a first step towards api.env without invalid values :-) (In my stash I have a patch which removes nonsense defaults from ipalib.constants. To be pushed when we a new git branch for 4.4...) Petr^2 Spacek >> server-install: Fix --hostname option to always override api.env values >> >> Attempts to compare local hostname with user-provided values are error >> prone as we found out in #5794. This patch removes comparison and makes >> the env values deterministic. >> >> https://fedorahosted.org/freeipa/ticket/6071 >> >> >> Jan, this patch set should fix problems you have seen in containers. -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
