mbasti-rh commented on a pull request """ I went through commit messages again and I changed my mind, NACK:
1) commit: Removed incorrect check for returncode This commit contains incorrect ticket, issue has not been fixed by this commit 2) commit: Several fixes in replica_promotion tests This does not have ticket, is okay to push it just to master? 3) All commits have different tickets, so I have to manually split hashes and put it to proper tickets. Leave it as is for this PR to avoid mess, but in future create one PR for one ticket """ See the full comment at https://github.com/freeipa/freeipa/pull/52#issuecomment-244906832
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
