pvoborni commented on a pull request
"""
nack for f72ae94
it needs this update
```diff
diff --git a/install/ui/src/freeipa/certificate.js
b/install/ui/src/freeipa/certificate.js
index ad7fd87..9ab4002 100755
--- a/install/ui/src/freeipa/certificate.js
+++ b/install/ui/src/freeipa/certificate.js
@@ -268,6 +268,7 @@ IPA.cert.revoke_dialog = function(spec, no_init) {
spec = spec || {};
spec.width = spec.width || 500;
+ spec.ok_label = spec.ok_label || '@i18n:buttons.revoke';
spec.sections = [
{
name: 'note',
@@ -308,12 +309,13 @@ IPA.cert.revoke_dialog = function(spec, no_init) {
}
];
- var that = IPA.dialog(spec);
+ var that = IPA.confirm_dialog(spec);
that.open = function() {
+
+ that.confirmed = false;
that.dialog_open();
that.set_cacn(that.facet.state.cacn);
-
};
that.get_reason = function() {
@@ -336,23 +338,6 @@ IPA.cert.revoke_dialog = function(spec, no_init) {
that.init = function() {
var note = text.get('@i18n:objects.cert.revoke_confirmation');
that.widgets.get_widget('note.note').html = note;
-
- that.create_button({
- name: 'revoke',
- label: '@i18n:buttons.revoke',
- click: function() {
- that.on_ok();
- that.close();
- }
- });
-
- that.create_button({
- name: 'cancel',
- label: '@i18n:buttons.cancel',
- click: function() {
- that.close();
- }
- });
};
```
ACK for 8622b9f and e874ac9 (#6238)
I'll create new separate pull requests for both #6238 and #6216. So that
#6238 can be pushed and aforementioned changes for #6216 reviewed.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/31#issuecomment-245094506
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
