URL: https://github.com/freeipa/freeipa/pull/108
Title: #108: Bump pki min version and add commentary about sub-CA revocation on 
delete

mbasti-rh commented:
"""
I don't think that bumping BuildRequires is needed

Also you are changing strings used for translations, so I'd use this change and 
rather add new things to doc string using 
http://www.freeipa.org/page/Coding_Best_Practices#Split_long_translatable_strings
 It will help translators in future
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/108#issuecomment-250439798
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to