URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion
HonzaCholasta commented:
"""
I see. The point is, `check_domain_level()` is supposed to check whether
replica promotion is possible or not in the current domain level, so it's weird
it has an expected domain level argument and even weirder to introduce
additional minimum domain level argument, when all it should have is a single
boolean argument saying wheter you want to promote or not:
```python
def check_domain_level(api, want_promote):
...
promote = current >= constants.DOMAIN_LEVEL_1
if promote != want_promote:
raise RuntimeError(message)
...
```
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/416#issuecomment-276334410
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
