URL: https://github.com/freeipa/freeipa/pull/660
Author: dkupka
 Title: #660: rpcserver.login_x509: Actually return reply from __call__ method
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/660/head:pr660
git checkout pr660
From 2440d7cc3fbb3e739e739051d9d47c5c0cba115b Mon Sep 17 00:00:00 2001
From: David Kupka <dku...@redhat.com>
Date: Mon, 27 Mar 2017 16:09:09 +0200
Subject: [PATCH] rpcserver.login_x509: Actually return reply from __call__
 method

__call__ didn't return causing internal error in wsgi application. Previously
this bug was hidden by some other error and the code worked even though it
shouldn't.

https://pagure.io/freeipa/issue/6819
---
 ipaserver/rpcserver.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaserver/rpcserver.py b/ipaserver/rpcserver.py
index be4e391..77ed7e1 100644
--- a/ipaserver/rpcserver.py
+++ b/ipaserver/rpcserver.py
@@ -842,7 +842,7 @@ def __call__(self, environ, start_response):
                 environ, start_response, 'KRB5CCNAME not set',
                 'Authentication failed')
 
-        super(login_x509, self).__call__(environ, start_response)
+        return super(login_x509, self).__call__(environ, start_response)
 
 
 class login_password(Backend, KerberosSession):
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to