URL: https://github.com/freeipa/freeipa/pull/692 Author: flo-renaud Title: #692: tests: add non-reg for idrange-add Action: opened
PR body: """ Add non regression test for issue 6404: when idrange-add is called with empty dom-name, the command returns ipa: ERROR: an internal error has occurred https://pagure.io/freeipa/issue/6404 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/692/head:pr692 git checkout pr692
From ae9c23b2dac14eb60a3ecb52258b01385f734ce8 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Wed, 5 Apr 2017 11:44:08 +0200 Subject: [PATCH] tests: add non-reg for idrange-add Add non regression test for issue 6404: when idrange-add is called with empty dom-name, the command returns ipa: ERROR: an internal error has occurred https://pagure.io/freeipa/issue/6404 --- ipatests/test_xmlrpc/test_range_plugin.py | 49 ++++++++++++++++++++++++++++++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/ipatests/test_xmlrpc/test_range_plugin.py b/ipatests/test_xmlrpc/test_range_plugin.py index d0f962a..0a8f66b 100644 --- a/ipatests/test_xmlrpc/test_range_plugin.py +++ b/ipatests/test_xmlrpc/test_range_plugin.py @@ -113,6 +113,12 @@ testrange8_base_rid = rid_shift + 700 testrange8_secondary_base_rid = rid_shift + 800 +testrange9 = u'testrange9' +testrange9_base_id = id_shift + 800 +testrange9_size = 50 +testrange9_base_rid = rid_shift + 800 +testrange9_secondary_base_rid = rid_shift + 1800 + # Domain ranges definitions # Domain1 - AD domain nonactive (not present in LDAP) @@ -416,7 +422,8 @@ def teardown_class(cls): cleanup_commands = [ ('idrange_del', [testrange1, testrange2, testrange3, testrange4, - testrange5, testrange6, testrange7, testrange8], + testrange5, testrange6, testrange7, testrange8, + testrange9], {'continue': True}), ('user_del', [user1], {}), ('group_del', [group1], {}), @@ -872,4 +879,44 @@ def teardown_class(cls): 'range.'), ), + # Test for bug 6404 + # if dom-name is empty, add should not fail + + dict( + desc='Create ID range %r' % (testrange9), + command=('idrange_add', [testrange9], + dict(ipanttrusteddomainname=None, + ipabaseid=testrange9_base_id, + ipaidrangesize=testrange9_size, + ipabaserid=testrange9_base_rid, + ipasecondarybaserid=testrange9_secondary_base_rid)), + expected=dict( + result=dict( + dn=DN(('cn', testrange9), ('cn', 'ranges'), ('cn', 'etc'), + api.env.basedn), + cn=[testrange9], + objectclass=[u'ipaIDrange', u'ipadomainidrange'], + ipabaseid=[unicode(testrange9_base_id)], + ipabaserid=[unicode(testrange9_base_rid)], + ipasecondarybaserid=[ + unicode(testrange9_secondary_base_rid)], + ipaidrangesize=[unicode(testrange9_size)], + iparangetyperaw=[u'ipa-local'], + iparangetype=[u'local domain range'], + ), + value=testrange9, + summary=u'Added ID range "%s"' % (testrange9), + ), + ), + + dict( + desc='Delete ID range %r' % testrange9, + command=('idrange_del', [testrange9], {}), + expected=dict( + result=dict(failed=[]), + value=[testrange9], + summary=u'Deleted ID range "%s"' % testrange9, + ), + ), + ]
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
