> Caveats:
> - It only adds AT&T size suffix where it's
> *really* neccessary (memory referencing).
> - It doesn't put 0x in front of hex numbers
> (I wanted to add this but remembered that's
> not right in intel syntax).
Hmmm. I'm wondering: why don't you simply have two separate routines
(i386_decode_text_intel and i386_decode_text_att, say). Then you could
easily change whatever you like, e.g. the hex number display (in Intel
typically with capital letters and without 0x, in AT&T typically with
small letters and with 0x) ...
The majority of the code is different anyway between the two.
For the suffix, I think the correct way would be to always add
the suffix according to the 'dc->operand_size' value. Special care
needs to be taken for the 'movswl' etc. instructions, which have *two*
suffixes in AT&T syntax.
> I also updated the README file. It was very
> out-of-date, I think it's better now.
I've applied this part of the patch. For the rest, do you want to
send me an updated patch?
Bye,
Ulrich
--
Ulrich Weigand,
IMMD 1, Universitaet Erlangen-Nuernberg,
Martensstr. 3, D-91058 Erlangen, Phone: +49 9131 85-7688
