>From "Mark J. Roberts" <[EMAIL PROTECTED]> >SimplifiedClient is also an example of how to use the library code. > >RequestClient's main() would work EXACTLY THE SAME if I replaced > > RequestClient client = new RequestClient(params); >with > SimplifiedClient client = new SimplifiedClient(params); > >and changed the two client.execute()'s to client.get()'s. > >But it would be 200 lines shorter. Now why is that evil? Where does it add >confusion? > >I still think it is stupid to have the same 200 lines of code in two >places (albeit with different method names). It is also stupid for every >client that wants to make a generic insert or request to duplicate >fillBuckets. Right. If there's reusable code sitting around in RequestClient, it should be taken out and put in something like ClientUtil and called from RequestClient so other people can use it without resorting to cut-and-paste. I don't know if this is the sort of thing SimplifiedClient is doing... is it documented somewhere? -- Benjamin Coates _______________________________________________ Freenet-dev mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/mailman/listinfo/freenet-dev
