On Fri, 25 Jul 2003, Alex Chen wrote:

> After digging into the rlm_counter code, I finally find out what went wrong.
> If there is a setting of 'allowed-servicetype' in the counter configuration,
> when the counter module will check for the 'Service-Type' in the accounting
> request when accounting stops.  If there is no 'Service-Type' attribute in
> the
> request, the module simply returns RLM_MODULE_NOOP, and nothing is done.
>
> After tracing through the code, I double checked the comments in
> radiusd.conf and
> got the following brief description:
>
>       #  The allowed-servicetype attribute can be used to only take
>       #  into account specific sessions. For example if a user first
>       #  logs in through a login menu and then selects ppp there will
>       #  be two sessions. One for Login-User and one for Framed-User
>       #  service type. We only need to take into account the second one.
>
> This may be clear to people always know much about the behavior.  For newbie
> like
> me it does not really bring a bell.
>
> I think more explanation of the configuration elements for counter will be
> great,
> or add some debug message in rlm_counter.c like:
>
> if((proto_vp = pairfind(request->packet->vps, PW_SERVICE_TYPE)) == NULL)
> {
>     DEBUG2("rlm_counter: Service-Type is not set in the request, returns
> 'noop'\n");
>     return RLM_MODULE_NOOP;

Ok I 've added a few more debug statements, Thanks



--
Kostas Kalevras         Network Operations Center
[EMAIL PROTECTED]       National Technical University of Athens, Greece
Work Phone:             +30 210 7721861
'Go back to the shadow' Gandalf

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Reply via email to