on 06/02/2012 19:54 Andriy Gapon said the following:
>
> I think that the following patch is needed for build correctness in
> libfreerdp-kbd. Without this patch the X11 headers either will not be in the
> include paths or will be there by chance. This patch is required on FreeBSD.
>
> --- libfreerdp-kbd/CMakeLists.txt.orig 2012-02-06 17:32:12.698938336
> +0200
> +++ libfreerdp-kbd/CMakeLists.txt 2012-02-06 17:33:23.503937964 +0200
> @@ -31,6 +31,7 @@
>
> find_suggested_package(X11)
> if(X11_FOUND)
> + include_directories(${X11_INCLUDE_DIRS})
> target_link_libraries(freerdp-kbd ${X11_LIBRARIES})
> endif()
>
>
What's the status of this issue?
I also have some additional correction to the build system.
1.
Some header file detection modules need a correction of the same type as
demonstrated here:
https://redports.org/browser/avg/net/freerdp/files/patch-cmake_FindX11.cmake
Why the current approach is not entirely correct is described in detail here
(using another example):
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/2808
2.
As demonstrated here:
https://redports.org/browser/avg/net/freerdp/files/patch-channels_drdynvc_tsmf_pulse_CMakeLists.txt
some target_link_libraries() statements neglect to provide a path to dependency
libraries. I think that it is better to use XXX_LDFLAGS because unlike
XXX_LIBRARIES they provide not only -lxxx flags, but -Lxxx and other necessary
flags as well.
Alternatively, XXX_LIBRARIES could still be used, but the other flags (most
importantly -L ones) should be additionally provided.
The above issues are quite real, but they are usually masked on GNU/Linux-based
systems where all headers are typically installed under /usr/include and all
libraries are in /usr/lib, so even of the module/library-specific flags are
incorrect a compiler is still able to find the headers and libraries on its own
via the standard search paths.
--
Andriy Gapon
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel
