Rats, I see there is a 0.96.2 in the works, so I'm
afraid the patches I have won't apply to head.
Actually, these are based upon SVN r1245 back
gefore Dayton.

Still, I would like to get these out for review.

fixup-string-handling.patch
plot-2.8-variation.patch
GetItemText-2.8-variation.patch
preprocess-wx-2.9-features.patch
HID-PTT

Let me describe these patches in this email, but
I will send them as separate emails later.

Whereas wxWidgets version 2.9 is a development
branch that will stabilize as version 3.0,

and whereas there is a great amount of similarity
between the 2.8 and 2.9 versions of wxWidgets,

I have made a stab at having fdmdv2 code support
both versions 2.8 and 2.9 of wxWidgets.

Step 1: It seems that with 2.9 it is possible to
be a little more sloppy with wxString types. So
the fixup-string-handling.patch adds back the
discipline on using wxT() and explicit string
conversion routines. This is bound to help things
stay more robust and avoid bugs. Also, since it
is possible to have variations of building
wxWidgets that either do or do not support
Unicode - this patch helps fdmdv2 work with either
mode. Applying fixup-string-handling.patch
still results in successful builds under 2.9,
while eliminating many problems building with 2.8.

Step 2: The various fdmdv2*plot* files have
2.9 only statements. The plot-2.8-variation.patch
keeps 2.9 support, and adds 2.8 support - since
the changes are relatively minor.

Step 3: GetItemText-2.8-variation.patch keeps
the same code for the 2.9 case, but for
compilation with 2.8 only uses the single
argument to GetItemText. This patch needs more
testing, but is likely to do the right thing.

Step 4: Some 2.9 only code remains in fdmdv2_main
after the other issues are taken care of. The
preprocess-wx-2.9-features.patch keeps them
for 2.9 compilation, but the absence of code
for the 2.8 case is likely to cause missing features.
I think selecting sound files for record and
playback is likely to not work for 2.8. This
will need additional attention from gui programmers.

And Step 5: I use a CMedia USB sound card and radio
interface that does PTT via USB HID.
The HID-PTT patch adds the capability to fdmdv2
to use that feature. This patch doesn't care
about wxWidgets version at all.

Individual patch emails to follow...
With all of these patches applied, things still
build with wxWidgets 2.9, but the way is prepared
to try 2.8 as well.

Comments especially welcome from David Rowe,
Dave Witten and Richard Shaw - as well as
any wxWidgets programmers out there.

In the meantime I will be updating these patches
to apply to SVN HEAD and 0.96.2 - but this
is sent in keeping with the release early, release
often code development strategy.

Thanks,
-Maitland

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
Freetel-codec2 mailing list
Freetel-codec2@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freetel-codec2

Reply via email to