> Following is my first manuscript patch to add the version checking
> feature to autogen.sh.  In addition to basic
> aclocal/libtoolize/autoconf, it scans aclocal-1.9, glibtoolize,
> libtoolize-1.5, autoconf-2.59 for fallbacking.

This looks good, thanks.  Some comments:

  . Please reduce the number of additional programs to the absolute
    minimum.  I think that you can both emulate `wc' and `head' with
    `sed'.

> +    vm=`echo ${min_version} | sed 's/\./ /g;s/[^0-9 ]/ &/g;s/ */,/g' `

  . I think that the definition of `vm' can be moved out of the
    branches since it looks the same in all cases.


      Werner


_______________________________________________
Freetype-devel mailing list
Freetype-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/freetype-devel

Reply via email to