>> This is not necessary, AFAICS. `psid' defaults to zero (this happens >> during allocation of the structure), which isn't a valid value. I've >> documented that properly. > > Humm?? Nameid zero is very valid...
No, it's not, see below. > I see you changed it to 0xFFFFFFFF though. I still like my patch > better. If postScriptNameID is available in fvar table but some > entries miss it, they will report 0xFFFF. So, you either should > convert those to 0xFFFFFFFF as well, or just do what my patch did. I was confused. Will change this. > Also, your patch says only namdID 6, ... valid. That's also wrong. ??? I see the following in https://www.microsoft.com/typography/otspec/delta181to182/fvar.htm: The postScriptNameID field provides a name ID that can be used to obtain strings from the 'name' table that can be treated as equivalent to name ID 6 (PostScript name) strings for the given instance. Values of 6 and 0xFFFF can be used; otherwise, values must be greater than 255 and less than 32768. If the value is 0xFFFF, then the value is ignored, and no PostScript name equivalent is provided for the instance. The value 6 should only be used if the named instance corresponds to the font's default instance. Werner _______________________________________________ Freetype-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/freetype-devel
