> I don't see a version test for Pygments in `requirements.txt'. then it must be a requirement of another requirement, indirectly dragged into the dependency graph. If you want to make sure the requirements.txt is exhaustive (includes all the required third-party modules, not just the top-level ones), you can do like this:
1) create a new virtual enviromnent, activate it, and install the top-level dependencies (this will also pull all the dependencies of the dependencies) 2) run `pip freeze > requirements.txt` (this will dump a list of all modules installed in the current environment, with exact version specifiers ==) 3) check in that file, and use it to re-create the same environment on the CI, as well as on the local developer's machine. On Fri, Jul 27, 2018 at 12:57 PM Werner LEMBERG <[email protected]> wrote: > > > It's not a good idea to have the `make refdoc` target call pip to > > install missing requirements in the user's python lib. > > Hmm. `make refdoc' is not a target that is to be called by Joe User. > It was always handled specially, i.e., it was assumed, for example, > that Python is available, without testing for its existence. > > > I don't want those packages to pollute my environment, if I just > > want to build the freetype documentation. > > > > You should either exit with error if the requirements are not met, > > and maybe tell the user to run pip install -r requirements.txt for > > themselves; > > Yes. Nikhil, please replace the call to `pip install' with a check > whether the necessary packages are available, emitting a list of > packages that the user has to install to proceed. > > > or you could bootstrap a new python virtual environment, [...] > > I don't have an opinion here since I'm not Python user. My gut > feeling, however, says that we should first try to make it run with > installed packages also. > > > This would also avoid issues like the one Werner reported where > > there is a conflict between the version of Pygments installed > > globally (via the distro package manager) and the one required by > > the docwriter. > > Hmm, I don't see a version test for Pygments in `requirements.txt'. > Nikhil? > > > Werner > -- Cosimo Lupo
_______________________________________________ Freetype-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/freetype-devel
