On Sun, 2003-11-30 at 06:27, SourceForge.net wrote: > > Initial Comment: > The summary says it, I suppose. Every time I have a psx > or gba game file with a space in the name, freevo > passes control to the game emulator in question, only > toreturn irritated moments later. > > When I change the spaces to underscores (for > instance), the game runs well. > > String handling? Argument passing?
Spaces in filenames should definitely be a user configurable item. I
for one prefer spaces in my filenames because on the recorded TV program
selection menu, it looks more natural with spaces in it. It also looks
better on the filesystem than all of those nasty underscores.
I had to make the following hacks to have spaces in my filenames, but it
works:
Index: freevo_config.py
===================================================================
RCS file: /cvsroot/freevo/freevo/freevo_config.py,v
retrieving revision 1.281
diff -u -r1.281 freevo_config.py
--- freevo_config.py 9 Nov 2003 13:06:15 -0000 1.281
+++ freevo_config.py 30 Nov 2003 13:56:34 -0000
@@ -1012,7 +1012,7 @@
'br=128:cbr:mode=3 ' + # MP3 const. bitrate, 128 kbit/s
'-ffourcc divx ' + # Force 'divx' ident, better compat.
'-endpos %(seconds)s ' + # only mencoder uses this so do it here.
- '-o %(filename)s.avi ') # Filled in by Freevo
+ '-o "%(filename)s.avi" ') # Filled in by Freevo
# XXX Not used yet
VCR_SETTINGS = '%s composite1 %s %s' % (CONF.tv, CONF.chanlist, TV_DEVICE)
Index: src/util/tv_util.py
===================================================================
RCS file: /cvsroot/freevo/freevo/src/util/tv_util.py,v
retrieving revision 1.1
diff -u -r1.1 tv_util.py
--- src/util/tv_util.py 11 Oct 2003 17:57:39 -0000 1.1
+++ src/util/tv_util.py 30 Nov 2003 13:56:37 -0000
@@ -50,7 +50,7 @@
'''Translate a program name to something that can be used as a filename.'''
# Letters that can be used in the filename
- ok = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_-:'
+ ok = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789_-: '
s = ''
for letter in progname:
Admittedly though I don't use mencoder for my VCR_CMD, so I have my own
local override in local_conf.py, but it has the filename quoted just as
the patch does above.
I also want to propose the following one-liner:
Index: src/tv/plugins/generic_record.py
===================================================================
RCS file: /cvsroot/freevo/freevo/src/tv/plugins/generic_record.py,v
retrieving revision 1.11
diff -u -r1.11 generic_record.py
--- src/tv/plugins/generic_record.py 19 Oct 2003 16:17:03 -0000 1.11
+++ src/tv/plugins/generic_record.py 30 Nov 2003 13:56:37 -0000
@@ -98,6 +98,7 @@
def Record(self, rec_prog):
cl_options = { 'channel' : rec_prog.tunerid,
'filename' : config.DIR_RECORD + '/' + rec_prog.filename,
+ 'base_filename' : rec_prog.filename,
'seconds' : rec_prog.rec_duration }
self.rec_command = config.VCR_CMD % cl_options
for VCR_CMDs that don't want the whole pathname, but just the base
filename to put the recorded content into (i.e. they take care of the
path themselves).
b.
--
My other computer is your Microsoft Windows server.
Brian J. Murrell
signature.asc
Description: This is a digitally signed message part
