On Sunday 17 April 2005 13:19, Dirk Meyer wrote: > Right now my version here supports both, the old vfs and the > .thumbnails style. But do we need both? To keep the code cleaner, I > want to remove the vfs way of thumbnailing. Comments on that? Seems like a good idea to me. :-) (Clean code with no *real* disadvantage.)
> [...] Second: do we need creating thumbnails with the cache helper? > Right now thumbnails are created on the fly, meaning you enter an > image dir and you see only the mimetype icon and file after file, the > image is shown (like other image viewers do). So what about removing > the thumbnail support in the cache helper? What about making the thumbnail creation optional with a cmdline option? E.g. "freevo cache" would skip thumbnails, but "freevo cache --thumbnails" (or --all/--complete/whatever) would also create them. AFAICS, the code would not be too complicated, so why remove it; I for example like calling "freevo cache" to update everything after populating my media directories, this gives me some nice summary of what nice things are new on the HD. :-) By the way, this reminds me of a bug I found these days: If you link freevo to "cache" to make the helper callable directly, the "-h" cmdline argument is still handled by freevo; e.g. "cache -h" gives the freevo help, in contrast to "freevo cache -h" which displays the help screen of cache.py. > To go further: the mediadb also stores the information in the > vfs. What about creating LIB_DIR/medtadb and store all cache files > there. Maybe the same for the .raw files of fxd files (pickled for > faster access). CACHE_DIR/fxd should do the trick. Doing that, the vfs > would be clean, containing only the files that are created by the > user. That'd reveal a whole new idea of the vfs directory; I always wondered why it's called "vfs" when it's more or less a cache directory.. ;-) Nice greetings, Hans
pgpBvVIuxLkCG.pgp
Description: PGP signature
