Dirk Meyer wrote:
Jason Tackaberry wrote:
>>>Yes, I also don't like it. But this we only wrap, we could set
| add_timer = addTimer
or we change it during import. The nf_generic has addTimer and we
rename it internal in kaa.notifier to add_timer. I agree, we should
keep one style and this style should be functions_like_this and
ClassLikeThis.
I think however we do it, they should get renamed to follow the style
guide. I'll defer to your better judgement. :)
kaa.notifier may use pyNotifier if it is installed. So this notifier
has addTimer in it. And we shouldn't change the code we copy, so I
vote for addTimer in nf_generic. BUT, in __init__ we could rename it
to add_timer, I have no problem with that. In fact, I would prefer
it. AddTimer isn't the way we should do it.
I've always used ClassesLikeThis, mothodsLikeThis, functions_like_this.
Ok, that may be a bit wierd as most people consider methods and
functions to be the same thing (I think) - and I can't recall if they
technically are. I've always treated methods as callable members of a
class and functions callable members of a module. Either way we do it
is fine with me, I can switch back and forth no problem and will follow
the current style of whatever I'm working on.
Yes, I agree with almost everything here except for the 80 column limit.
When I write code for my own project, I get to pick my own style. If my
terms are 130 columns wide, I want to use that space. :) But if yours
are only 80, then we'll use 80. The extra space makes a big difference
IMHO, but if you're limited by resolution, I don't want to write code
that looks ugly for other project members.
Again, I could switch to 80 chars. Since right now everything is from
one of us plus Rob, I guess we three should define a max width. Please
not more than 130 beacuse it won't fit. IF we use more than 80, we
should use 120.
I have no problems with over 80 characters, in fact I'd prefer a bit
more. The display I'm using as I type this email is 1600x1200 and I use
fullscreen terminals. However at home I'm using a 17" monotor @
1024x768 so I'll have to check when my max character width is.
-Rob
--
-------------------------------------------------------
Rob Shortt | http://tvcentric.com | Freevo
[EMAIL PROTECTED] | http://freevo.sf.net | Free your TV
-------------------------------------------------------
This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
core and dual graphics technology at this free one hour event hosted by HP,
AMD, and NVIDIA. To register visit http://www.hp.com/go/dualwebinar
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
