Bugs item #1568856, was opened at 2006-10-01 18:59
Message generated for change (Comment added) made by rvpaasen
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1568856&group_id=46652
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: players
Group: 1.5.x svn
Status: Open
Resolution: Accepted
Priority: 7
Submitted By: John Molohan (johnmolohan)
Assigned to: Nobody/Anonymous (nobody)
Summary: Pygame error: traceback with ivtv_xine_tv and directfb
Initial Comment:
Hi,
Just got this one after installing directfb. Freevo ran
fine and so did tv. I watched, changed channels and
paused no problem the on pressing stop on the remote
got this:
SDL DirectFB_SetVideoMode: [EMAIL PROTECTED], flags: 0x00000000
Traceback (most recent call last):
File
"/usr/lib/python2.4/site-packages/freevo/main.py", line
520, in ?
osd.clearscreen(color=osd.COL_BLACK)
File
"/usr/lib/python2.4/site-packages/freevo/osd.py", line
611, in clearscreen
self.screen.fill(self._sdlcol(color))
error: display Surface quit
Traceback (most recent call last):
File
"/usr/lib/python2.4/site-packages/freevo/main.py", line
539, in ?
shutdown()
File
"/usr/lib/python2.4/site-packages/freevo/plugins/shutdown.py",
line 76, in shutdown
osd.clearscreen(color=osd.COL_BLACK)
File
"/usr/lib/python2.4/site-packages/freevo/osd.py", line
611, in clearscreen
self.screen.fill(self._sdlcol(color))
pygame.error: display Surface quit
ivtv_xine_tv.py (430): XineThread: Stopped
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-10 19:15
Message:
Logged In: YES
user_id=182311
Could you restore the version of this plugin that was in svn
last week? It had exception handling added.
Also, there are two places where you forgot to add the
player=True parameter in the getVideoGroup() call.
I'll try and add the stop command for directfb then.
Thanks.
----------------------------------------------------------------------
Comment By: Duncan Webb (duncanwebb)
Date: 2006-10-10 18:50
Message:
Logged In: YES
user_id=104395
Hi Richard,
I've done as you suggested, the updated version has been
committed in r8343.
_Here is a gotcha_
/home/freevotest/freevo/src/tv/ivtv_xine_tv.py
the plugin has now moved to
/home/freevotest/freevo/src/tv/plugins/ivtv_xine_tv.py
You will need to delete the build directory and the
/home/freevotest/freevo/src/tv/ivtv_xine_tv.py* files before
installing the new version.
_Also_
I've updated the plugin for the multi-tuner stuff. I can
test the df_xine when John returns.
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-10 17:08
Message:
Logged In: YES
user_id=182311
Why don't we revert the ivtv_xine_tv plugin to the one that
works for x11/xine and try to fix it for fb/xine?
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-10 17:06
Message:
Logged In: YES
user_id=182311
With the current plugin I get the following error with x11/xine:
PLAY CHAN: rtl4
Traceback (most recent call last):
File "/home/freevotest/freevo/src/main.py", line 321, in
eventhandler
app.eventhandler(event)
File "/home/freevotest/freevo/src/menu.py", line 425, in
eventhandler
if not isinstance(menu, Menu) and menu.eventhandler(event):
File "/home/freevotest/freevo/src/tv/tvguide.py", line
211, in eventhandler
self.player('tv', self.selected.channel_id)
File "/home/freevotest/freevo/src/tv/tvmenu.py", line 100,
in start_tv
plugin.getbyname(plugin.TV).Play(mode, tuner_id)
File "/home/freevotest/freevo/src/tv/ivtv_xine_tv.py",
line 122, in Play
vg = self.current_vg = self.fc.getVideoGroup(tuner_channel)
TypeError: getVideoGroup() takes exactly 3 arguments (2 given)
----------------------------------------------------------------------
Comment By: Duncan Webb (duncanwebb)
Date: 2006-10-10 16:27
Message:
Logged In: YES
user_id=104395
I think we have a bit of a mess with this plug-in.
The current plug-in in svn generates:
/usr/bin/xine --hide-gui -pq -g -B --geometry 720x576+0+0
--no-splash -V --no-splash --no-lirc --stdctl --no-lirc
--post=pp:quality=10;expand pvr:///home/livetv
This looks completely incorrect, no argument to -V
>From what I see from the patches that have been sent the
correct version doesn't work for John using fbxine and the
current version doesn't work for xine.
Richard, will you tell me what you think the current status is?
John, what it the correct command line when using df_xine? I
don't think that the current modules gives you the correct
command line either.
----------------------------------------------------------------------
Comment By: Duncan Webb (duncanwebb)
Date: 2006-10-06 10:05
Message:
Logged In: YES
user_id=104395
Thanks John for this information. I'll close this bug report
and if you figure out a fix then please create a new one.
----------------------------------------------------------------------
Comment By: John Molohan (johnmolohan)
Date: 2006-10-06 08:44
Message:
Logged In: YES
user_id=774680
Thanks for the input Richard. I'm away in the next few hours
until next Tuesday but I'll try figure out a fix for this
next week (might use Richard's version but add some checking
for directfb and if so use old kill method).
----------------------------------------------------------------------
Comment By: John Molohan (johnmolohan)
Date: 2006-10-06 08:36
Message:
Logged In: YES
user_id=774680
svn now seems to be working as expected
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-05 20:39
Message:
Logged In: YES
user_id=182311
The difference between the two modules is that the old one
uses the kill command on xine to stop it. The new one uses
the "quit" command via stdctl. The latter gives a better
response, the freevo tvguide reappears faster.
After quiting xine, it cleans up the buffer files for live
tv and that takes some time. Xine thus keeps running for a
while when the tvguide has already been displayed (the video
device is closed so another xine instance can be started if
needed).
Unfortunately I don't have directfb on my machine to test.
You could try to replace the new quit call with the old kill
call and see if that works. Adding an extra sleep after the
quit may also help. Ideally, ivtv_xine_tv should wait for
the child proces to finish; but then a delay between stop
and tvguide is introduced again.
I don't know why this porblem occurs with directfb and not
with x11.
----------------------------------------------------------------------
Comment By: Duncan Webb (duncanwebb)
Date: 2006-10-04 04:46
Message:
Logged In: YES
user_id=104395
Reverted to old source as you have suggested. There may be
some benfits with newer version. I see that player start and
stop messages are sent.
Changed in r8314 and I've fixed the tabs in r8315.
Will you check the svn version?
Maybe Richard will fix this?
----------------------------------------------------------------------
Comment By: John Molohan (johnmolohan)
Date: 2006-10-03 22:44
Message:
Logged In: YES
user_id=774680
I just tested this with the original version of the
ivtv_xine plugin that I had and it does not crash. See
attached files. The updated version of the plugin uses a
different method to try and close xine and this appears to
be the root of the problem. In fact the updated plugin gives
me no OSD either so I'm not really seeing any benifits from
it at the moment.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1568856&group_id=46652
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
