TC Wan wrote:
> Hi,
> I'm not sure if it's better to post to the SF Bugtracker, or straight to
> the list, so I'm sending it here first.

In this case the Bug tracker. I don't mind it this is a feature or a bug
and in this case as I would consider it an enhancement so it its a
feature. The reason is this is something that requires something to be
changed and an update to the change log.

> I've had to update the radioplayer.py code to accomodate alternative
> radio players other than the one supplied by xawtv, since xawtv is no
> longer packaged for Fedora Core 5. I'm currently using fmtools which is
> probably the closest in terms of syntax to the xawtv radio cmd.

Thanks for the patch it looks good.


> Enclosed is the patch I'm using, but it should be generalized to accept
> a RADIO_CMD which is specified in local_config.py.
> 
> 
> In freevo_config.py / local_config.py:
> 
> RADIO_CMD = 'fm'
> RADIO_CMD_START = ('%s -q %s 65535' % (RADIO_CMD, %(station)))
> RADIO_CMD_STOP = ('%s -q off' % RADIO_CMD)
> 
> In radioplayer.py:
> 
> (I'm not familiar with python to fix this properly, so the following
> probably isn't valid python syntax)
> 
> --- freevo-1.5.4/src/audio/plugins/radioplayer.py.orig  2006-09-07
> 08:31:26.000000000 +0800
> +++ freevo-1.5.4/src/audio/plugins/radioplayer.py       2006-09-07
> 08:31:26.000000000 +0800
> @@ -111,7 +111,7 @@
>              mixer.setMicVolume(config.TV_IN_VOLUME)
>          else:
>              print 'Radio Player failed to find a mixer'
> -        os.system('%s -qf %s' % (config.RADIO_CMD, self.item.station))
> +        os.system('%s' % (config.RADIO_CMD_START, self.item.station))
>          thread.start_new_thread(self.__update_thread, ())
>          return None
> 
> @@ -129,7 +129,7 @@
>              mixer.setMicVolume(0)
>          else:
>              print 'Radio Player failed to find a mixer'
> -        os.system('%s -qm' % config.RADIO_CMD)
> +        os.system('%s' % config.RADIO_CMD_STOP)
> 
> 

------------------------------------------------------------------------

--- freevo-1.5.4/src/audio/plugins/radioplayer.py.orig  2006-09-07
08:31:26.000000000 +0800
+++ freevo-1.5.4/src/audio/plugins/radioplayer.py       2006-09-07
08:31:26.000000000 +0800
@@ -111,7 +111,7 @@
             mixer.setMicVolume(config.TV_IN_VOLUME)
         else:
             print 'Radio Player failed to find a mixer'
-        os.system('%s -qf %s' % (config.RADIO_CMD, self.item.station))
+        os.system('%s -q %s 65535' % (config.RADIO_CMD, self.item.station))
         thread.start_new_thread(self.__update_thread, ())
         return None

@@ -129,7 +129,7 @@
             mixer.setMicVolume(0)
         else:
             print 'Radio Player failed to find a mixer'
-        os.system('%s -qm' % config.RADIO_CMD)
+        os.system('%s -q off' % config.RADIO_CMD)


     def is_playing(self):


------------------------------------------------------------------------

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job
easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642


------------------------------------------------------------------------

_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to