Bugs item #1586106, was opened at 2006-10-28 00:02
Message generated for change (Comment added) made by richjoyce
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1586106&group_id=46652
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: plugins
Group: 1.6.0
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ehisey (ehisey)
Assigned to: Nobody/Anonymous (nobody)
Summary: Game plugin crashes on bad zipfiles
Initial Comment:
The freevo game plugin crashes when scanning an snes
rom directoy and hits a corrupt zipfile. The crash
occurs at in freevo/games/zipped_rom.py.
I think best solution would be to try catch the error
before freevo crashes and report the bad zip file to
the user. That way the plugin should be able to scan
the rest of the directories and function normally.
----------------------------------------------------------------------
Comment By: Richard Joyce (richjoyce)
Date: 2006-11-06 19:14
Message:
Logged In: YES
user_id=601845
Heres what I get when I add a bad zip file (`touch
corrupt.zip`) to my SNES directory (It crashes, won't load
the dir):
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/freevo/main.py",
line 321, in eventhandler
app.eventhandler(event)
File "/usr/lib/python2.4/site-packages/freevo/menu.py",
line 605, in eventhandler
action( arg=arg, menuw=self )
File
"/usr/lib/python2.4/site-packages/freevo/directory.py", line
451, in cwd
self.check_password_and_build(arg=None, menuw=menuw)
File
"/usr/lib/python2.4/site-packages/freevo/directory.py", line
506, in check_password_and_build
self.build(arg=arg, menuw=menuw)
File
"/usr/lib/python2.4/site-packages/freevo/directory.py", line
612, in build
for i in p.get(self, files):
File
"/usr/lib/python2.4/site-packages/freevo/games/__init__.py",
line 99, in get
items += [ SnesItem(file, cmd, args, imgpath, parent) ]
File
"/usr/lib/python2.4/site-packages/freevo/games/snesitem.py",
line 244, in __init__
(self['romName'],self['romHL'],self['romMem'],self['romROM'],self['romSRAM'],self['romCountry'],self['romLic'],self['romVer'],self['romICHK'],self['romCHK'])
= self._read_rom(snesFile)
File
"/usr/lib/python2.4/site-packages/freevo/games/snesitem.py",
line 316, in _read_rom
return
(romName,romHL,romMem,romROM,romSRAM,romCountry,romLic,romVer,romICHK,romCHK)
UnboundLocalError: local variable 'romHL' referenced before
assignment
----------------------------------------------------------------------
Comment By: Duncan Webb (duncanwebb)
Date: 2006-10-28 02:29
Message:
Logged In: YES
user_id=104395
Need more infomation, such as a crash log.
If a bad zip crashed freevo, then it needs fixing. If it
leaves a nasty message in the log, then it will catch the eye.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1586106&group_id=46652
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
