On Thu, 2006-12-28 at 22:06 +0100, Dirk Meyer wrote:
> Yes and no. I don't see a big difference in making it int except
> easier to read when int. 

I seem to remember us having this discussion before. :)

It may be easier to read when it's an int, but this is a presentation
issue.  kaa.metadata's job is to provide as much detailed information
about a file as possible.  It makes no sense to me that kaa.metadata
should go out of its way to actually discard precision for purposes of
formatting.


> BTW, did you broke beacon with that change
> (type detection?)

Hm.  Beacon looks broken, but not because of this change:

ERROR yieldfunc(205): YieldFunction
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/kaa/notifier/yieldfunc.py", line 201, 
in _step
    result = self._yield__function()
  File "/usr/lib/python2.4/site-packages/kaa/beacon/server/crawl.py", line 499, 
in _scan
    counter += parse(self.db, child, check_image=self._startup) * 20
  File "/usr/lib/python2.4/site-packages/kaa/beacon/server/parser.py", line 
223, in parse
    if type == 'video' and not attributes.get('image') and \
AttributeError: 'module' object has no attribute 'SUPPORT_VIDEO'
ERROR async(84): InProgress exception: 'module' object has no attribute 
'SUPPORT_VIDEO'

But I suppose you mean because length attributes are set as type int in
the db?  No, kaa.db will do coercion between numeric types.  But the
length attribute should be a float in beacon; I've changed this.

Jason.


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to