Jason Tackaberry wrote:
> On Tue, 2007-01-16 at 18:08 +0100, Dirk Meyer wrote:
>> >          if isinstance(self._window, kaa.display.X11Window) or 1:
>> > -            wid = hex(self._window.get_id())
>> > +            wid = "0x%x" % self._window.get_id()
>> >              if wid.endswith('L'):
>> >                  wid = wid[:-1]
>> >              display = self._window.get_display().get_string()
>> 
>> Is there a reason for this?
>
> Yes, because wid is a long now, so hex(wid) is 0xfooL which mplayer
> can't parse.  So this needed to be fixed.  Could be hex(wid)[:-1] but I
> prefer the form "0x%x" % wid, as it's clearer I think and also works
> whether wid is a long or int.

Take a look at the patch again and also read the two lines after your
patch and tell me again why you changed that. :)


Dischi

-- 
Hit any user to continue.

Attachment: pgpKcteK144CN.pgp
Description: PGP signature

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to