Duncan Webb wrote: > On Mon, 22 January, 2007 2:23 am, mike lewis wrote: >> On 1/21/07, Mathias Weber <[EMAIL PROTECTED]> wrote: >> >>> Hi >>> >>> >>> I added support for a network remote via TCP connection. Before I send >>> a patch I want to now how i should handle the case that i need some new >>> config values? Just add them in local_conf.py.example and >>> freevo_config.py. Do I need to specify my change some where else? I >>> have seen that there are version information in the config file. >>> >> Hi, I'm not a uber-dev or anything. But this is the norm. >> >> >> 1) Defaults in freevo_config.py >> 2) Local settings in local_config.py (ie if you need to voerride the >> defaults) 3) The plugin should return it's own settings documentation via >> the config function. (ie freevo -i cd_burn > > Spot on :) > > The configuration item, which I found out this weekend, are set when a > 'config' function is defined. The return value is a list of settings. IIRC > If the settings are not defined in the config files then the plug-in uses > the settings from the config function. > > It's a quite neat feature that very few plug-in use. > > When you send in the patch please add the settings to freevo_config.py and > local_conf.py.example. > > BTW In video/plugins/reencode2.py and plugins/idlebar/encoding.py are > doing just about everything possible that is GUI related. Item submenus, > changing the screen refresh rate on the fly, (changing the polling > interval), idlebar graphics and even a bit of functionality too :) > > Duncan > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Freevo-devel mailing list > Freevo-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/freevo-devel >
Ok i see, maybe i have done it not the correct way, since i just hacked rc.py and added support for TcpNetwork just as it was for Network. I will add the patch tomorrow to the tracker, you may give some comments and then i can fix it the way it should be. Mathias ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
