Dirk Meyer wrote:
> 
> OK. But do not include it into plugin.py and make an keep it an extra
> file.

ok you are right.

> ... The
> functions isApplication and isPlugin are not really needed, you could
> ask isinstance.

I think isinstance is fine. So I will drop the resource_type.

> Another idea: create the RessourceUser class. Application inherits
> From this class, Plugin does not. IF you have a plugin that uses
> ressource you inherit from both Plugin and RessourceUser.

Yes that is better i think.

> 
> in application/base.py:
> 
> class Application(RessourceUser):
>     def resource_type(self):
>         return 'application'

I will leave this since we could use isinstance.

> in your plugin:
> 
> class PluginInterface(InputPlugin, RessourcePlugin):
> 
>> The Plugin class and the Application class would both be inherited from 
>> the RessourceUser class (Maybe you have a better name for it).
> 
> RessourceHandler?

Jap i think this is better.

> 
>> I will do this changes if you think it is a good Idea or maybe you
>> got even a better idea.
> 
> What do you think of this idea? Also notice the names of the
> functions. I think it is a good idea to start all functions with the
> names where they belong too.

I see that you already do start the functions with the names. but 
actually this are methods in usually you don't do this with methods this 
is something done in c because there where no encapsulation. But this is 
something i can adopt for this project.

Thanks for your comments.

Mathias

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to