On Tue, 2007-22-05 at 10:33 +0200, Dirk Meyer wrote: > It is a special case with self._vo_settings[0] = True. I had the > straneg bug that aspect changes between two frames between two > values. I have no idea why.
I think this can happen with broken xine plugins. There used to be a problem with expand that would cause varying pixel aspects as you paused/unpaused. I don't think this should happen anymore. Can you explain under what circumstances you saw this? If this is a workaround to some xinelib bug then ok, but I'd like to better understand/document it. > This includes the aspect. Do you have files where the aspect changes > two times between frames? Yes. I have an mpeg-ps file, a DVB capture. It starts with a 4/3 aspect, and then the program begins and it switches to 16/9. All part of the same stream. > > > # keep given video aspect in calculation (in most cases 1.0) > > - aspect *= vid_a > > + # Why multiply by vid_a? This isn't right. > > + # aspect *= vid_a > > So what is? I had a video where this is what I needed to make it > work. We need to calculate with vid_a at some point. This is admittedly tricky. :) I can say that multiplying by vid_a here is definitely wrong. We start with _stream_settings['pixel-aspect'] being 1.0 which is correct for my display as my display has square pixels. But then it gets multiplied by the video's pixel aspect. Consequently we're telling xine my display has non-square pixels. Yes the pixel aspect does need to be worked into the computation. But it is already. Twice in fact. Once in _get_vo_display_size() where we determine the window size based on the pixel aspect, and again inside xine's engine. And the pixel aspect is independent of the _display_ aspect, which is what we're returning. Maybe in the SCALE_4_3 or SCALE_16_9 cases we'll need to fudge the display aspect return value, but we don't need to in the normal case. Can you provide me a clip of the video you had problems with? (BTW, _stream_settings should be renamed to something more clear, because at first I was trying to figure out why the stream's pixel aspect was 1.0, because that's not right. Or maybe just rename pixel-aspect to display-pixel-aspect so I'm not confused with the stream pixel aspect.) Jason. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Freevo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freevo-devel
