On Thu, 2008-03-27 at 08:21 +0000, Adam Charrett wrote:
> This patch adds several new methods to X11Window which adds the ability
> to set the shape mask for the window (either from a bitmask string or an
> imlib2 image) and disable/enable windows decorations. I've also included
> a test app that shows the new features in use.

Thanks for the patch.  It looks mostly good (although the formatting
style is slightly different than the existing code, this can be
changed), except for this:

> -    { "set_title", (PyCFunction)X11Window_PyObject__set_title, METH_VARARGS 
> },
> -    { "get_title", (PyCFunction)X11Window_PyObject__get_title, METH_VARARGS 
> },
> -    { "get_children", (PyCFunction)X11Window_PyObject__get_children, 
> METH_VARARGS },
> -    { "get_parent", (PyCFunction)X11Window_PyObject__get_parent, 
> METH_VARARGS },
> -    { "get_properties", (PyCFunction)X11Window_PyObject__get_properties, 
> METH_VARARGS },
> +    { "set_shape_mask", (PyCFunction)X11Window_PyObject__set_shape_mask, 
> METH_VARARGS },
> +    { "reset_shape_mask", (PyCFunction)X11Window_PyObject__reset_shape_mask, 
> METH_VARARGS },
> +    { "set_decorated", (PyCFunction)X11Window_PyObject__set_decorated, 
> METH_VARARGS },

Why are you removing all these methods?

Thanks,
Jason.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to