On Mon, 2008-11-17 at 14:49 +0100, Dirk Meyer wrote: > > + def _update_read_monitor(self, signal=None, change=None): > + """ > + Update read IOMonitor to register or unregister based on if there are > + any handlers attached to the read signals. If there are no handlers, > + there is no point in reading data from the channel since it will go > + nowhere. This function will deactivate this functionality while > + performing the TLS handshake. > + """ > + if self._handshake: > + return > + return super(TLSSocket, self)._update_read_monitor(signal, change)
Implementing this method should not be necessary. If the IOChannel is not involved at all in the TLS handshake then the function you should change is TLSSocket._is_read_connected(). Currently it returns true if self._handshake is True. It sounds like it should return False in that case. So it should be: return not self._handshake and super(TLSSocket, self)._is_read_connected() ... and then my comment in that function should be fixed, as it's wrong. Jason. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
