Hans Meine wrote:
> On Donnerstag 25 Dezember 2008, Duncan Webb wrote:
>> The number of chapters should be len(chapters)
>> [...]
>> -                    <if expression="chapters">
>> -                        <text font="info value" expression="chapters"/>
>> +                    <if expression="len(chapters)">
>> +                        <text font="info value"
> 
> <nitpick>Maybe the if-expression should have remained "chapters".
> Rationale: chapters without len is more safe, since it works not only for 
> empty lists but e.g. also for None.</nitpick>
> 
> Anyhow, I assume you tested this and it works with the current code.
> Just my 2 cents.

I noticed a problem when switching over to the Panorama the number of
chapters was being displayed as a list of dicts. Comparing this to the
blurr skin the number of chapters was correct and the difference was the
 if expression. Now it works correctly.

Duncan

------------------------------------------------------------------------------
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to