Jason Tackaberry wrote: > On Wed, 2009-05-27 at 21:25 +0200, Matthias Reichl wrote: >> - A wrong start_pos is returned if no header could be found in >> the first 64k block >> - It won't find a header if it crosses the 64k block boundary >> (for example when the header starts at byte 65535) > > The irony is that one of motivations behind writing the new function was > to catch the case where the header spans the 64k boundary, because I > noticed the original eyeD3 function had this bug while reading the code. > Clearly I did not test it. > > I've committed a modified version of your patch to correct the two > issues you spotted. I also tested all 3 cases where the 4-byte header > could span the boundary, which is something I should have done the first > time. :) > > Thanks Matthias.
New release? Dischi -- WARNING: I cannot be held responsible for the above, as apparently my cats have learned how to type. ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
