hi,

On Fri, Jun 12, 2009 at 10:26:14AM +0200, A Mennucc wrote:
> file '/usr/share/pyshared/freevo/video/videoitem.py'

recently , we did some work so that now
a 'RemovableMedia' instance (see rom_drives.py)
 contain methods mount() and umount()
that implement a reference counting 

reference counting is very important,
since many different part of freevo may be accessing
the media together (e.g. the DirWatcher, the 
encoding server (*) etc etc)

an instance of  'RemovableMedia' is available as 'self.media'
in all stuff that is an instance of a class derived from
'Item' , and this means, AFAIK in every object representing 
a file (in a very general sense) in Freevo

for all above reason, it  is bad and evil
to use  utils.umount() directly

but video/videoitem.py and video/plugins/mplayer.py
contains a lot of calls of util.mount()

this must be replaced to calls to the appropriate method

a.

ps (*) we need to add a media.mount() media.umount() to
 the encoding server indeed, it is in my TODO list

ps2: it would be important to notify the users
 visually if the drive is locked ; this is 
very important in particular for USB drives
(in case we come to implement a GUI interface to that)

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to