Thanks for adding this feature, Adam. Some comments:
On 11-08-07 06:53 AM, Adam Charrett wrote:
> -def _get_display(display):
> +def get_display(display=None):
> + """
> + Get a display object for the specfied display.
> + @param display: The name of the display to return (in standard X11
> format) or
> + None for the default display.
> + @return: An X11Display object for the specified display.
We've been using rEST in kaa for some time now. But I see kaa.display
is still using the old style. I've added this to the TODO.
> + if 'composite' in kwargs and kwargs['composite']:
if kwargs.get('composite') is a useful idiom.
> + for (i = 0; i< nvi; i++)
> + {
> + format = XRenderFindVisualFormat (dpy, xvi[i].visual);
> + if (format->type == PictTypeDirect&& format->direct.alphaMask)
> + {
> + visual = xvi[i].visual;
> + break;
> + }
> + }
The rest of the code uses K&R for bracket placements, so we should
follow this style rather than mixing two different styles. Ditto for
the space between function name and open paren.
Don't worry too much about going back over this now, but if you're
poking around these parts in the future, feel free to tweak it.
Thanks!
Jason.
------------------------------------------------------------------------------
BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
The must-attend event for mobile developers. Connect with experts.
Get tools for creating Super Apps. See the latest technologies.
Sessions, hands-on labs, demos & much more. Register early & save!
http://p.sf.net/sfu/rim-blackberry-1
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel
