[EMAIL PROTECTED] dixit:
Explanation:
>-PKG_SOURCE:= $(PKG_NAME)-$(PKG_VERSION).tar.gz
This is already implied by the *.mk files, no need to add.
(Besides, why are you using $(FOO) and not ${FOO} ?)
>- (cd $(WRKBUILD); rm -rf config.{cache,status} ; \
>+ cd $(WRKBUILD); rm -rf config.{cache,status}; \
>- );
Invoking a subshell isn't necessary here, the entire command
is already run in a subshell.
>+ --disable-dependency-tracking \
>+ --disable-libtool-lock \
>+ --enable-fast-install
Speeds up one-time builds like the ones we do and makes
the build output much more readable.
Of course, some configure scripts might not know these
options, just leave these which are not supported.
>- $(INSTALL_DIR) $(IDIR_FOOBAR)/etc/init.d/
>+ $(INSTALL_DIR) $(IDIR_FOOBAR)/etc/init.d
We create that directory, so it must be the last pathname component.
>- $(INSTALL_DATA) ./files/foobar.conf $(IDIR_FOOBAR)/etc
>+ $(INSTALL_DATA) ./files/foobar.conf $(IDIR_FOOBAR)/etc/
The contrary case - we install foobar.conf into .../etc/ so the
trailing slash is used to point out to install(1) that we're
installing _info_ .../etc/ (otherwise, if $(IDIR_FOOBAR)/etc
does not exist, it becomes a FILE).
>- /usr/sbin/foobar
>+ /usr/sbin/foobar $foobar
If "foobar=NO" in /etc/rc.conf, we disable the service.
Otherwise, we use it as flags. Use "foobar=" to enable
the service. ("foobar=''" works too but is redundant.)
>- $0 stop
>- $0 start
>+ $0 stop && $0 start
Only start the service if stopping it succeeded.
Comment about killall vs pkill has already been given.
Hint: try killall on a Solaris ;)
//mirabile
--
I believe no one can invent an algorithm. One just happens to hit upon it
when God enlightens him. Or only God invents algorithms, we merely copy them.
If you don't believe in God, just consider God as Nature if you won't deny
existence. -- Coywolf Qi Hunt
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers
