On Fri, 2007-03-30 at 19:28 +0000, Thorsten Glaser wrote:
> >Won't it be easier to just fix the buildscript then?
> 
> Send a diff, I'll review and test it on a system that has neither cc nor gcc.

Attatched.

> >I think such constructs add unneeded complexity and abstraction.
> 
> Yes, I think that too. Fix the broken build systems. For example
> that of the Linux kernel, if my memory serves me right.

Yeah, don't hack around the problem, solve it at the source.
Index: Makefile
===================================================================
--- Makefile	(revision 2312)
+++ Makefile	(working copy)
@@ -120,14 +120,6 @@
 	@env NO_ERROR=${NO_ERROR} BASH="$$(lbin/which bash)" \
 	    CC='${CC}' CPPFLAGS='${CPPFLAGS}' \
 	    bash ${_PX} scripts/scan-tools.sh
-	@cc='${CC}'; if test x"$$cc" = x"gcc"; then \
-		ln -s $$(lbin/which "$$cc") lbin/gcc; \
-	else \
-		( echo "#!$$(lbin/which bash)"; \
-		  echo "export PATH=$$PATH"; \
-		  echo "exec $$cc" '"$$@"' ) >lbin/gcc; \
-		chmod 555 lbin/gcc; \
-	fi
 	@${GMAKE_INV} tools/install-lbin
 	@echo '===> Prerequisites checked successfully.'
 	@touch $@
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers

Reply via email to