On Thu, Aug 02, 2007 at 10:13:54AM +0000, Thorsten Glaser wrote:
> [EMAIL PROTECTED] dixit:
>
> >* dropping exotic IPSec encryption algorithm to save space
>
> You remember what happened last time when someone dropped
> algorithms? Correct! Users complained because this broke
> their VPN setups.

Yes, but this time it was really dead code.

>
> >+-CONFIG_KLIPS_ALG_BLOWFISH=m
> >++CONFIG_KLIPS_ALG_BLOWFISH=n
>
> You know that this one is probably the fastest block cipher
> algorithm out there which is still secure, and has a very
> small code size (I implemented it in x86 asm in <100 Bytes)?

Dead code.

>
> >+-CONFIG_KLIPS_ALG_MD5=m
> >+-CONFIG_KLIPS_ALG_SHA1=m
> >+-CONFIG_KLIPS_ALG_SHA2=m
> >++CONFIG_KLIPS_ALG_MD5=n
> >++CONFIG_KLIPS_ALG_SHA1=n
> >++CONFIG_KLIPS_ALG_SHA2=n
>
> I don't really understand why you're disabling these standard hashes?

Dead code. I can reenable it, but this should be fixed upstream.

Suggestion. I revert these changes not to confuse anybody.

Dirk
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers

Reply via email to