On Wed, May 22, 2024 at 10:10:16PM +0800, Qian Yun wrote:
> This patch fixes many memory issues related with title --
> especially with long titles in graphs.
>
> The fix includes:
>
> 1. memory overwrite in 'spadAction'
>
> (1) -> vp := draw(x,x=1..2); title(vp, new(100, "a".1)$String)
> Compiling function %C with type DoubleFloat -> DoubleFloat
> Graph data being transmitted to the viewport manager...
> FriCAS2D data being transmitted to the viewport manager...
> X Error of failed request: BadWindow (invalid Window parameter)
> Major opcode of failed request: 3 (X_GetWindowAttributes)
> Resource id in failed request: 0x61616161
> Serial number of failed request: 777
> Current serial number in output stream: 778
>
> 2. buffer overflow in 'makeViewport'
>
> 3. memory leakage in 'funView2D'/'funView3D'
>
> (if you run "title" in a loop)
It is good to fix buffer overflow. But you also remove error
checking (use of 'check'). Admited, this is minimal error
checking, just printing error message, but this is better than
nothing.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to fricas-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/Zk_O-SOn0WpvMnqQ%40fricas.org.
