On Mon, May 19, 2008 at 11:09:50AM +0000, Cory Burgett <[EMAIL PROTECTED]> 
wrote:
> +pkgname=luasocket
> +pkgver=2.0.2
> +pkgrel=1
> +pkgdesc="network support for the Lua language"
> +url="http://www.tecgraf.puc-rio.br/~diego/professional/luasocket/";
> +depends=('lua')
> +groups=('lib-extra')
> +archs=('i686')
> +up2date="lynx -dump http://luaforge.net/projects/luasocket/|grep -m1 
> 'Released'|sed 's/.*et \(.*\) .*/\1/'"
> +source=(http://luaforge.net/frs/download.php/2664/$pkgname-$pkgver.tar.gz 
> $pkgname-$pkgver-config.diff)

that was a false suggestion, we try to keep line length under 80 chars.

> +sha1sums=('5ce521fc5c6efb7c1eba7f36dfeafa9e4d745464' 
> '8dfac5f60302d15bb57544a931bfdf147aa5b557')

here here.

> +build()
> +{
> +     Fcd
> +     Fpatchall
> +     make all || Fdie
> +     make INSTALL_TOP=$Fdestdir/usr install || Fdie

you can just do an:

Fpatchall
Fmake
Fmakeinstall INSTALL_TOP=$Fdestdir/usr

that's just simpler :)

> +@@ -30,8 +30,9 @@
> + #
> + #INSTALL_TOP_SHARE=/usr/local/share/lua/5.0
> + #INSTALL_TOP_LIB=/usr/local/lib/lua/5.0
> +-INSTALL_TOP_SHARE=/usr/local/share/lua/5.1
> +-INSTALL_TOP_LIB=/usr/local/lib/lua/5.1
> ++INSTALL_TOP ?= /usr
> ++INSTALL_TOP_SHARE = $(INSTALL_TOP)/share/lua/5.1
> ++INSTALL_TOP_LIB = $(INSTALL_TOP)/lib/lua/5.1
> + 
> + INSTALL_DATA=cp
> + INSTALL_EXEC=cp

if you:

+INSTALL_TOP ?= /usr/local

that would still work, and there is a chance it would be even accepted
by upstream! :)

the rest looks ok, pushed.

i would appropriate if you could try to send the patch to upstream, at
least the first hunk definitely seems something like they could accept.

thanks!

Attachment: pgpz1gcGt8VPh.pgp
Description: PGP signature

_______________________________________________
Frugalware-devel mailing list
[email protected]
http://frugalware.org/mailman/listinfo/frugalware-devel

Reply via email to