James Buren wrote:
> Git-Url:
> http://git.frugalware.org/gitweb/gitweb.cgi?p=frugalware-current.git;a=commitdiff;h=1829d961d2a44034e03e69bc52d1d8c2e82bb5e8
>
> commit 1829d961d2a44034e03e69bc52d1d8c2e82bb5e8
> Author: James Buren <[EMAIL PROTECTED]>
> Date: Sat Jun 28 03:57:18 2008 -0500
>
> cairo-dock-20080622-1-i686
> * new package
>
> diff --git a/source/x11-extra/cairo-dock/FrugalBuild
> b/source/x11-extra/cairo-dock/FrugalBuild
> new file mode 100644
> index 0000000..00e9560
> --- /dev/null
> +++ b/source/x11-extra/cairo-dock/FrugalBuild
> @@ -0,0 +1,58 @@
> +# Compiling Time: 1 SBU
> +# Maintainer: James Buren <[EMAIL PROTECTED]>
> +
> +pkgname=cairo-dock
> +pkgver=20080622
> +pkgrel=1
> +pkgdesc="A lightweight dock built with cairo."
> +url="http://www.cairo-dock.org/";
> +options=('scriptlet' 'nodocs')
> +depends=('librsvg' 'dbus-glib' 'libxtst' 'libxcomposite')
Do you use chkdep ? you are missing some depends ..
....
cairo-dock-20080622-1-x86_64.fpm
depends=('libxcomposite' 'libgl' 'libxmu' 'libice' 'librsvg' 'freetype2'
'dbus-glib' 'libxtst' 'libxau' 'libxdmcp' 'libxdamage')
....
> +makedepends=('intltool' 'doxygen' 'alsa-lib' 'vte')
> +groups=('x11-extra')
> +archs=('i686' 'x86_64')
> +_F_archive_name=$pkgname-sources
> +up2date="Flasttar
> http://developer.berlios.de/project/showfiles.php?group_id=8724";
> +source=(http://download.berlios.de/$pkgname/$pkgname-sources-$pkgver.tar.bz2)
> +sha1sums=('f35c207623d2d74a057e46f1eee479cd61417c04')
> +subpkgs=("$pkgname-plugins" "$pkgname-themes")
> +subdescs=("Plugins for $pkgname." "Themes for $pkgname.")
> +subrodepends=("$pkgname alsa-lib vte" "$pkgname")
These are wrong too and twice :
1)
cairo-dock-plugins-20080622-1-x86_64.fpm
depends=('libxtst' 'libgl' 'libice' 'libxmu' 'librsvg' 'libxau' 'libxdmcp'
'dbus-glib' 'libxdamage' 'alsa-lib' 'vte' 'ncurses' 'libxft')
2) for -plugins subpackage these are subdepends so you need :
subdepends=('depends_here' '')
subrodepends=('' 'the_rodepends')
> +subgroups=("x11-extra" "xlib-extra")
> +subarchs=("i686 x86_64" "i686 x86_64")
> +
> +build()
> +{
> + Fcd $pkgname
> + # generate doxygen docs
> + cd doc || Fdie
> + ./generate-doc.sh || Fdie
> + cd .. || Fdie
> + # reconfig, and install first component
> + Fautoreconf
> + Fconf --enable-glitz
> + make LDFLAGS="-lXcomposite" || Fdie
What you want is :
make LDFLAGS="$LDFLAGS -lXcomposite"
> + Fmakeinstall
> + Fdocrel {INSTALL,LICENSE}
> + Fcprel doc/html /usr/share/doc/$pkgname-$pkgver
> + # fix execute permissions
> + Fdirschmod /usr/bin +x
> + # install, and split plugins
> + cd ../plug-ins || Fdie
> + Fautoreconf
> + PKG_CONFIG_PATH="$Fdestdir/usr/lib/pkgconfig"
> + Fconf
> + make CC="gcc -I$Fdestdir/usr/include/$pkgname
> -I$Fdestdir/usr/include/$pkgname/$pkgname" || Fdie
CC , CXX is to set the compiler , what you want here are CPPFLAGS.
> + Fmakeinstall
> + Fsplit $pkgname-plugins /usr/lib/$pkgname
> + for i in $Fdestdir/usr/share/locale/*/LC_MESSAGES/cd-*.mo; do
> + Fsplit $pkgname-plugins `echo $i | sed 's|^.*/pkg||'`
> + done
> + # install, and split themes
> + cd ../themes || Fdie
> + Fautoreconf
> + Fbuild
> + Fsplit $pkgname-themes /usr/share/$pkgname/themes
That one is wrong , without at least /usr/share/cairo-dock/themes/_default_/
the package is broken so that one
has to be in main package.
> +}
> +
> +# optimization OK
Other Issues :
main package need a desktop file.
you have to change the default 'applications' ( and that for each theme I guess
) , eg:
default browser / files browser points to nautilus , media player to
beep-media-player etc.
change to something generic we have a lot apps in the repos,
Why the default theme talks french to me ? please change that to be at least
english.
Since you extra build devel docs you may want to add $pkgname-docs and split
/usr/share/doc/cairo-dock-*/html/ ,
no one need near 8MB devel docs.
And btw could you please take care a bit ?
crazy
_______________________________________________
Frugalware-devel mailing list
[email protected]
http://frugalware.org/mailman/listinfo/frugalware-devel
