On Fri, Jul 04, 2008 at 06:24:16PM +0200, j3d1f0x <[EMAIL PROTECTED]> wrote: > source=($source $pkgname.png $pkgname-$pkgver-cmake.patch > http://downloads.sourceforge.net/$pkgname/oamenace-data-$pkgver.tar.bz2 > http://downloads.sourceforge.net/$pkgname/oamenace-lang-en-$pkgver.tar.bz2 > http://downloads.sourceforge.net/$pkgname/oamenace-lang-de-$pkgver.tar.bz2 > http://downloads.sourceforge.net/$pkgname/oamenace-lang-ru-$pkgver.tar.bz2)
this one is a bit hackish, but at least you don't hardwire a mirror :)
what about using ${source/openamenace-src/oamenace-lang-en}
${source/openamenace-src/oamenace-lang-de} and so on?
> #building
> Fcd
> CMake_make
unnecessary Fcd, see include/cmake.sh :)
> --- CMakeLists.txt 2008/02/15 09:55:15 33
> +++ CMakeLists.txt 2008/05/19 08:11:36 36
> @@ -13,6 +13,8 @@
> # ./AstroMenace
> #
>
> +CMAKE_MINIMUM_REQUIRED(VERSION 2.4)
> +
> # project name
> PROJECT(AstroMenace)
>
are you sure this hunk is necessary? or is this some backport from
svn/cvs/etc?
> @@ -43,9 +45,12 @@
> IF(DEFINED DATADIR)
> ADD_DEFINITIONS(-DDATADIR=\\"${DATADIR}\\")
> ENDIF(DEFINED DATADIR)
> - ADD_DEFINITIONS(`${SDL_CONFIG} --cflags` -Wall)
> + EXEC_PROGRAM(${SDL_CONFIG} ARGS "--cflags" OUTPUT_VARIABLE SDL_CFLAGS)
> + EXEC_PROGRAM(${SDL_CONFIG} ARGS "--libs" OUTPUT_VARIABLE SDL_LIBS)
> +
> + ADD_DEFINITIONS(${SDL_CFLAGS})
> ADD_EXECUTABLE(AstroMenace ${astromenace_SRCS})
> - TARGET_LINK_LIBRARIES(AstroMenace `${SDL_CONFIG} --libs`
> ${OPENGL_gl_LIBRARY} ${OPENAL_LIBRARY} ${JPEG_LIBRARY} ${GLU_LIBRARY} -lalut
> -lvorbis -lvorbisfile)
> + TARGET_LINK_LIBRARIES(AstroMenace ${SDL_LIBS} ${OPENGL_gl_LIBRARY}
> ${OPENAL_LIBRARY} ${JPEG_LIBRARY} ${GLU_LIBRARY} -lalut -lvorbis -lvorbisfile)
> IF(CYGWIN)
> TARGET_LINK_LIBRARIES(AstroMenace -lGL.dll -lGLU.dll -lglfw -lX11.dll)
> # ADD_DEFINITIONS(-mno-cygwin)
i'm sure these are necessary but you could add a short description in
the patch header about why this is necessary. and also about if you sent
this to upsream or not, etc.
here is a good template for such patch headers:
Submitted By: <author of the patch. you or you took it from an other
distro, etc.>
Upstream Status: <if submitted, optionally url to the
bugtracker/mailing list, or state of it's
frugalware-specific.>
Description: <short desc about why the patch is necessary>
other than that, looks ok.
pgp2jSiG2YyCI.pgp
Description: PGP signature
_______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
