Hello,
Miklos Vajna wrote:
General question: I'm happy to see you reused code from the existing setup. In
long term, do you want a merge? I mean using #ifdef GTK around your code,
#ifdef DIALOG around dialog code, and using a common repo for both of the setup.
Pro: you don't have to merge bugfixes in the common code part to
fwife, so in long term you get the bugfixes automatically without wasting your
time.
Con: doing the merge costs some time.
I think it would worth in long term, but I don't know what is your preference
here.
First, even if parts of code is reused, i make many "little" differences
to do what I wanted and "adapt" plugins to gtk. For exemple plugint_t
struct is bigger in fwife than in curse installer. Or in some plugins I
add just one line in a GList ( i think of partdisk plugin)!
A merge is possible but, in my view, it would make the code
unnecessarily big, dirty and, in a long term, more difficult to maintain
for both installers.
And I think that, with time, differences between both installers will
increase.
Second, i used fw libraries (libpacman, libfwgrubconfig,
libfwtimeconfig, etc...) as much as possible. So all that code is
(indirectly) shared.
Elentir
_______________________________________________
Frugalware-devel mailing list
[email protected]
http://frugalware.org/mailman/listinfo/frugalware-devel
